Channels
#kotlin-fuel
- k
kittinunf
11/12/2018, 1:57 AMHaha - k
kittinunf
11/12/2018, 1:58 AMOkay ;) - d
Derk-Jan Karrenbeld
11/12/2018, 1:58 AMalso qq, I have fixed the android sample on master. Can you do a quick review in say 3 minutes so we can merge it so that worker8 can continue his thing? - d
Derk-Jan Karrenbeld
11/12/2018, 1:59 AM(just waiting for it to compile now) - k
kittinunf
11/12/2018, 1:59 AMYes yes - k
kittinunf
11/12/2018, 1:59 AMI am on the train to work now - d
Derk-Jan Karrenbeld
11/12/2018, 1:59 AMsweet - d
Derk-Jan Karrenbeld
11/12/2018, 2:00 AMI'll ping in a minute then - d
Derk-Jan Karrenbeld
11/12/2018, 2:12 AM@kittinunf https://github.com/kittinunf/Fuel/pull/524 - k
kittinunf
11/12/2018, 2:13 AM👀 - d
Derk-Jan Karrenbeld
11/12/2018, 2:13 AM😛 - k
kittinunf
11/12/2018, 2:17 AMI see … do you think there will be a case where user really want to do something with the request in the response block? - d
Derk-Jan Karrenbeld
11/12/2018, 2:18 AMYou can still regular print it! - k
kittinunf
11/12/2018, 2:18 AMmaybe checking the param/ or body - d
Derk-Jan Karrenbeld
11/12/2018, 2:18 AMJust not curlprint - k
kittinunf
11/12/2018, 2:18 AMah true - d
Derk-Jan Karrenbeld
11/12/2018, 2:18 AMIf you want to do something with the body after it has been sent, you could do: val myMemoryBody = request.body.toByteArray() before you call .response or .await - d
Derk-Jan Karrenbeld
11/12/2018, 2:19 AMThen you load the entire body into memory, and it's all good 🙂 - k
kittinunf
11/12/2018, 2:19 AMbecause of this line right?val escapedBody = String(getHttpBody()).replace("\"", "\\\"") - k
kittinunf
11/12/2018, 2:19 AM👍 - d
Derk-Jan Karrenbeld
11/12/2018, 2:19 AMyou got it - d
Derk-Jan Karrenbeld
11/12/2018, 2:20 AMIf the body comes from an external read-once stream you don't want to curl it after it has been sent anyway; by forcing the read-once policy, we can even make secure bodies you can't load completely into memory without reflection hacking - k
kittinunf
11/12/2018, 2:20 AMyeah agree - d
Derk-Jan Karrenbeld
11/12/2018, 2:21 AMForcing the user to think about that was a change to fix all those memory issues -- and the bug reports around "why is my stream called twice" - k
kittinunf
11/12/2018, 2:21 AMjust thinking about a case we in debug mode we don’t care too much about that - d
Derk-Jan Karrenbeld
11/12/2018, 2:21 AMOh yeah, I can add that easily after my big PR if you'd like - k
kittinunf
11/12/2018, 2:21 AMmaybe we should have a
or.debug()
where we load it into the memory.log() - d
Derk-Jan Karrenbeld
11/12/2018, 2:21 AMit's a trivial change to make it an option - k
kittinunf
11/12/2018, 2:21 AMyeah - d
Derk-Jan Karrenbeld
11/12/2018, 2:22 AMAlso, in a future PR I'll change the error message for curl, and actually make it say something like "(the body was omitted because it was already processed. make sure you call curlString before you send the request)"