https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • i

    itnoles

    11/12/2018, 4:16 PM
    1) you can't do RxJava and un-multiplatform libraries.
  • k

    kittinunf

    11/12/2018, 4:21 PM
    @Derk-Jan Karrenbeld I think I have done one round of review. It looks awesome 👏 💯
  • k

    kittinunf

    11/12/2018, 4:22 PM
    my chrome = 🤯 💥 💣
  • i

    itnoles

    11/12/2018, 4:29 PM
    weird remove "apply false" then bintray {} working
  • i

    itnoles

    11/12/2018, 4:41 PM
    @kittinunf is that interesting?
  • k

    kittinunf

    11/12/2018, 4:42 PM
    I am all in if you can improve on that
  • k

    kittinunf

    11/12/2018, 4:42 PM
    Gradle is like ⚫ 🔮
  • i

    itnoles

    11/12/2018, 4:42 PM
    Kotlin DSL doesn't help
  • i

    itnoles

    11/12/2018, 4:53 PM
    oh boy, HTTP/3 😞
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 4:56 PM
    oh boy, HTTP/3 😞
    😄
  • i

    itnoles

    11/12/2018, 5:00 PM
    it seems Android's HttpUrlConnection is based on OkHttp.
  • i

    itnoles

    11/12/2018, 5:00 PM
    that made sense
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 5:01 PM
    Yes! It is 🙂
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 5:01 PM
    @kittinunf finished your review, and comment here: https://github.com/kittinunf/Fuel/pull/512#discussion_r232734304
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 5:03 PM
    https://github.com/kittinunf/Fuel/pull/512/commits/8a53093b5cb56d3ee9f51815ade9250e27d94822 here start the recent changes btw, if you're trying to see it in chrome XD
  • i

    itnoles

    11/12/2018, 5:06 PM
    intriging on by line on object
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 5:07 PM
    You mean:
    Copy code
    object Fuel : RequestFactory.Convenience by FuelManager.instance
    😛 ?
  • i

    itnoles

    11/12/2018, 7:03 PM
    ya
  • d

    Derk-Jan Karrenbeld

    11/12/2018, 7:05 PM
    Isn't it nice 😏 . All 
    FuelManager
    now has the same 
    .get
    etc methods as 
    Fuel.
    , so it's easier to have separate `FuelManager`s! And use it interchangably
  • i

    itnoles

    11/12/2018, 7:05 PM
    yes
  • i

    itnoles

    11/12/2018, 7:06 PM
    I am glad to see corountines have own packages.
    K 1
  • d

    Derk-Jan Karrenbeld

    11/13/2018, 3:19 AM
    Of course! They should haha
  • i

    itnoles

    11/13/2018, 3:25 AM
    Did you noticed some build noise on certain files?
    👍 1
  • d

    Derk-Jan Karrenbeld

    11/13/2018, 3:26 AM
    I have not removed the debug logging yet 🙂
  • d

    Derk-Jan Karrenbeld

    11/13/2018, 3:26 AM
    (In other words: it's supposed to do that hehe)
  • d

    Derk-Jan Karrenbeld

    11/13/2018, 3:27 AM
    Yep ^_^ fixing all those 🙂
  • i

    itnoles

    11/13/2018, 3:29 AM
    I wish there is a better checks for these dependencies.
  • i

    itnoles

    11/13/2018, 3:37 AM
    i hate when to get stuck with more dependencies to maintain
  • n

    Nikky

    11/13/2018, 3:41 AM
    i was considering something that would experimentally remove compile dependencies and report if something compiled with dependencies removed
  • n

    Nikky

    11/13/2018, 3:41 AM
    for that kind of usecase.. i then failed to deal with gradle and groovy
1...616263...118Latest