Channels
#kotlin-fuel
- i
itnoles
11/14/2018, 12:14 AMGroovy doesn't have that magic beans. - i
itnoles
11/14/2018, 12:15 AM@Nikky I made a new PR about new Kotlin versions and other. 🙂 - n
Nikky
11/14/2018, 4:18 AMi think this is the plugin DSL which is a part of gradle.. no different in groovy or kotlin apart from the syntax of the
calls differingid() - n
Nikky
11/14/2018, 4:21 AMthe PR looks good, very minimal and all tests pass - i
itnoles
11/14/2018, 4:24 AMhttps://github.com/ben-manes/gradle-versions-plugin looks cool, all it need to create tasks to depend on check - i
itnoles
11/14/2018, 4:34 AM@Nikky Android Studio doesn't support Kotlin DSL extremely well. - d
Derk-Jan Karrenbeld
11/14/2018, 8:01 PMI'm halfway done with the documentation. I think this is a good time to start writing more wiki with examples. What do you guys think? - i
itnoles
11/15/2018, 3:06 AMI guess worker8 has no time. - i
itnoles
11/15/2018, 3:07 AMI am wondering about Android Q would bring. - d
Derk-Jan Karrenbeld
11/15/2018, 3:13 AMNo, we are removing all the
annotations I think@jvm - i
itnoles
11/15/2018, 3:13 AMon your PR, I see some @JvmOverloads - d
Derk-Jan Karrenbeld
11/15/2018, 3:22 AMI have not yet removed them. We didn't make that decision until two days ago :) - i
itnoles
11/15/2018, 3:23 AMI was wondering about it,. - d
Derk-Jan Karrenbeld
11/15/2018, 3:32 AM:) - i
itnoles
11/15/2018, 3:36 AMI wish I can provide hooks to help worker8 - i
itnoles
11/15/2018, 3:38 AMGitHub syntax highlighting is extremely weird. - i
itnoles
11/15/2018, 3:49 AM@Derk-Jan Karrenbeld Do you want me to create a PR to move JSONObject-releated files into the fuel-core? - i
itnoles
11/15/2018, 3:49 AMfrom fuel-android - d
Derk-Jan Karrenbeld
11/15/2018, 3:50 AMSure! Sounds good :) - k
kittinunf
11/15/2018, 4:42 AMbtw … I am a bit skeptical about this … should we add Json dependency into the core? - i
itnoles
11/15/2018, 4:44 AM@kittinunf we already have testCompile of it in the core. - k
kittinunf
11/15/2018, 4:45 AMbut test is not affecting client of our library ? - d
Derk-Jan Karrenbeld
11/15/2018, 4:45 AMIt doesn't - d
Derk-Jan Karrenbeld
11/15/2018, 4:45 AMIt shouldn't be in the android lib either then haha. But probably its own thang - k
kittinunf
11/15/2018, 4:45 AMyeah i think that seems to be a better choice for me - k
kittinunf
11/15/2018, 4:46 AMi feel like we shouldn’t add any dependency if it is not absolutely necessary - d
Derk-Jan Karrenbeld
11/15/2018, 4:46 AMfuel-json would be fine - k
kittinunf
11/15/2018, 4:46 AMyep - k
kittinunf
11/15/2018, 4:46 AM🙂 - i
itnoles
11/15/2018, 4:46 AMoh okay.