https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    11/15/2018, 4:46 AM
    unless you don’t agree with me
  • d

    Derk-Jan Karrenbeld

    11/15/2018, 4:46 AM
    But extracting it out of android is a good idea!
  • k

    kittinunf

    11/15/2018, 4:47 AM
    yea
  • k

    kittinunf

    11/15/2018, 4:47 AM
    but probably not going into the core …
  • i

    itnoles

    11/15/2018, 4:47 AM
    I just closed the PR for new changes.
  • k

    kittinunf

    11/15/2018, 4:47 AM
    i will close the PR @itnoles if that is okay for you
  • k

    kittinunf

    11/15/2018, 4:47 AM
    oh you just did … 😛
  • i

    itnoles

    11/15/2018, 5:13 AM
    I am going to check it tomorrow morning.
  • d

    Derk-Jan Karrenbeld

    11/16/2018, 2:18 AM
    @itnoles where / when did you get the Android 28 warning? Do you know how I can trigger that?
  • d

    Derk-Jan Karrenbeld

    11/16/2018, 2:19 AM
    Apart from that I am done
  • i

    itnoles

    11/16/2018, 3:03 AM
    @Derk-Jan Karrenbeld I guess errors
  • d

    Derk-Jan Karrenbeld

    11/16/2018, 3:03 AM
    Oki
  • i

    itnoles

    11/16/2018, 3:51 AM
    @Derk-Jan Karrenbeld mine PR passed in despite coverage.
  • i

    itnoles

    11/16/2018, 3:58 AM
    I wish Android OEM provides better phones with better update cycles.
    😓 1
  • i

    igor.wojda

    11/16/2018, 11:45 AM
    Hello is there a way to specify default serialiser? instead of passing 
    gsonDeserializerOf()
    eachtime?
    Copy code
    val (_, _, result) = Fuel.get(endpoint).awaitObjectResponse<List<ProductNetworkModel>>(
            gsonDeserializerOf()
        )
    👍 1
  • n

    Nikky

    11/16/2018, 12:13 PM
    yeah coroutines and anything with serializers is currently not that userfriendly
  • n

    Nikky

    11/16/2018, 12:14 PM
    maybe we could add a default serializer to FuelManager
  • d

    Derk-Jan Karrenbeld

    11/16/2018, 2:58 PM
    This is coming with 2.0.0
  • d

    Derk-Jan Karrenbeld

    11/16/2018, 3:01 PM
    @Mark Gilchrist @itnoles @Nikky, @kittinunf has given go ahead for https://github.com/kittinunf/Fuel/pull/512. If you can check it out again and approve, I can merge it (and clean up the merge commit message).
  • i

    itnoles

    11/16/2018, 4:45 PM
    Forcing people to use corountines?
  • n

    Nikky

    11/17/2018, 12:13 PM
    if it fails wit ha COnnectException that is not handled as a FuelError
  • n

    Nikky

    11/17/2018, 12:14 PM
    something is going wrong again when i have to catch them all manually
  • n

    Nikky

    11/17/2018, 12:25 PM
    in some part of the suspending request flow from 
    awaitStringResponse
    it is not handling all Exceptions
  • n

    Nikky

    11/17/2018, 1:20 PM
    small PR, but not sure i thats the right way to handle it.. and possibly leaves behind dead code.. not sure
  • n

    Nikky

    11/17/2018, 1:20 PM
  • k

    kittinunf

    11/19/2018, 2:02 AM
    I am backkk
    🎉 2
  • k

    kittinunf

    11/19/2018, 2:02 AM
    sorry for missing all the actions!!!
  • k

    kittinunf

    11/19/2018, 2:32 PM
    ByteArrayTest.response fails on my local machine though
  • k

    kittinunf

    11/19/2018, 2:32 PM
    is anyone experiencing this?
  • k

    kittinunf

    11/19/2018, 2:32 PM
    I will try to push and see whether it works on CI
1...646566...118Latest