https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • n

    Nikky

    11/23/2018, 4:03 AM
    those look good .. yes
  • n

    Nikky

    11/23/2018, 4:03 AM
    wait.. install ?
  • n

    Nikky

    11/23/2018, 4:03 AM
    it should be doing publishToMavenLocal right ?
  • i

    itnoles

    11/23/2018, 4:03 AM
    i guess
  • i

    itnoles

    11/23/2018, 4:04 AM
  • k

    kittinunf

    11/23/2018, 4:04 AM
    do you think this is a good idea https://github.com/kittinunf/Fuel/pull/543/files ?
  • k

    kittinunf

    11/23/2018, 4:04 AM
    wanna help you guys out
  • i

    itnoles

    11/23/2018, 4:05 AM
    @kittinunf you can use like 2.0.0-SNAPSHOT as a version for snapshot builds
  • n

    Nikky

    11/23/2018, 4:06 AM
    i would bump the version and append 
    -SNPASHOT
  • k

    kittinunf

    11/23/2018, 4:06 AM
    i don’t wanna complicate things so i think what i am gonna do is 
    master-SNAPSHOT
    and that is it
  • n

    Nikky

    11/23/2018, 4:06 AM
    but yes.. good idea..
  • k

    kittinunf

    11/23/2018, 4:06 AM
    do you think it is okay haha?
  • i

    itnoles

    11/23/2018, 4:06 AM
    jitpack uses <branch>-SNAPSHOT or version-SNAPSHOT
  • k

    kittinunf

    11/23/2018, 4:06 AM
    yea but I will publish on bintray
  • k

    kittinunf

    11/23/2018, 4:07 AM
    so we don’t have to care about jitpack thingy anymore
  • i

    itnoles

    11/23/2018, 4:07 AM
    bintray has own snapshot repo
  • n

    Nikky

    11/23/2018, 4:08 AM
    version = version = Fuel.publishVersion + if(isSnapshot) "-SNAPSHOT" else ""
  • n

    Nikky

    11/23/2018, 4:08 AM
    or so
  • i

    itnoles

    11/23/2018, 4:09 AM
    i believe snapshot should be in com.jfrog.artifactory
  • k

    kittinunf

    11/23/2018, 4:09 AM
    yea but once we bump version to 2.0.0 and merge to master
  • k

    kittinunf

    11/23/2018, 4:09 AM
    it will publish 2.0.0-SNAPSHOT which is kinda wrong
  • k

    kittinunf

    11/23/2018, 4:09 AM
    until we bump the version for the next iteration again
  • n

    Nikky

    11/23/2018, 4:10 AM
    i guess we have to bump version directly after a release ?
  • k

    kittinunf

    11/23/2018, 4:10 AM
    ah …
  • k

    kittinunf

    11/23/2018, 4:10 AM
    we can do that
  • i

    itnoles

    11/23/2018, 4:10 AM
    i think we should move publish version outside of buildSrc into root build gradle for easier editing
  • k

    kittinunf

    11/23/2018, 4:10 AM
    right now we (I) am doing this manually
  • n

    Nikky

    11/23/2018, 4:11 AM
    the alternative is to automatically parse the version and bump it in the buildscript only for snapshot version but that WILL go wrong
  • k

    kittinunf

    11/23/2018, 4:11 AM
    really? i think buid gradle on the contray is so fragile and harder for editing
  • n

    Nikky

    11/23/2018, 4:11 AM
    i know.. i tried.. i burnt myself
1...676869...118Latest