We need to add beta 2 support.

That will come out pretty shortly after simple smile

Hey guys (@kittinunf @yoavst), I’m trying to call the url https://api.github.com/search/repositories?q=android+language:kotlin&sort=updated&order=desc from Fuel. I do this by using a base url https://api.github.com/search/repositories and adding the parameters as list of Pairs. the

q

parameter is where I hit an issue. I want it to have the value

android language:kotlin

so I add it to a the list as

"q" to "android language:kotlin”

. But I seem to hit a duplicate encoding issue where the result is

q=android+language%253Akotlin

.

The colon

:

is encoded to

%3A

which in turn gets encoded as

%253A

Am I doing something wrong or did I indeed hit an issue (same code worked in previous versions of Fuel, now on 0.6)

If I understand you right, it worked on 0.57?

let me check what version I was on

yes 57

it’s this piece of code https://github.com/mplatvoet/kovenant-android-demo/blob/master/app/src/main/java/github.kt#L39

I'll take a look on it tomorrow (23:40 here). I guess it is something with URI class. Fuel used Uri before general java support.

thanks!

@mplatvoet: Sorry to hear that Mark, it seems to be a bug for me.

@mplatvoet: I have fixed that for you. I will push 0.62 up to fix this in an hour

Thanks @kittinunf !

It is supposed to be

<https://api.github.com/search/repositories?q=android%20language:kotlin&sort=updated&order=desc>

right?

yes, or https://api.github.com/search/repositories?q=android+language%3Akotlin&sort=updated&order=desc

a single pass encoding is also fine (and probably even more desirable)

0.62 is out to fix that @mplatvoet Can you help me check whether it fixes your issue?

Great, I'm able to check in about 5 hours

works great, thanks again

now available in my little demo app https://github.com/mplatvoet/kovenant-android-demo

Yeahhh, so sorry that should not have happened in fact.

I need more test coverages in encoding module.

hey guys

just wondering how does the fuel donwload call work with the file

@hon: It is just a simple GET to download content and write into a FileStream in whatever location you specify

Let me know if that doesn’t answer your question.

We are working on version 0.65. Change is mainly to use

Result

instead. So, it favors

Result.Success

&

Result.Failure

to check success/failure of the operation after network call is finished. It leads to better understanding than the old

Either

version of

Left

&

Right

.

I think it's a welcomed and understandable change. I do however doubt the change of the order of decomposing the object. You've chosen for left for success result where it's common for "right to be right". What is your motivation?

I understand. It boils down to the fact that I believe

Success

is something more desirable than

Failure

. So it comes first in the type declaration as

Result<V, E>

. To be consistent,

component1()

and

component2()

should be ordered in the same way.