https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • n

    Nikky

    11/27/2018, 8:51 PM
    i will be happy reveiwing the PRs
  • d

    Derk-Jan Karrenbeld

    11/27/2018, 10:30 PM
    Can you review my latest and open an issue for (separate for moshi, Jackson, kotlinx and forge)
  • d

    Derk-Jan Karrenbeld

    11/27/2018, 10:37 PM
    Then I or someone can pick them up
  • i

    itnoles

    11/27/2018, 11:10 PM
    RFC?
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 1:16 AM
    Another new PR open ^_^
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 1:17 AM
    Both are < 350 lines changed 😛
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 1:17 AM
    (instead of 20k)
  • i

    itnoles

    11/28/2018, 4:08 AM
    @Derk-Jan Karrenbeld How to find Fuel Manager is not resetting correctly?
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:08 AM
    Basically it should be reset ANYWHERE we change anything of the instance fuelmanager
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:08 AM
    such as baseParams or baseHeaders
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:08 AM
    I thought I got them all, but apparently not
  • i

    itnoles

    11/28/2018, 4:09 AM
    I see one in RequestHandlerTest
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:10 AM
    hah
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:10 AM
    that's it
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:10 AM
    Do you want to open a pr to fix it?
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:10 AM
    Instead of init, use @Before and @After
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:10 AM
    in @Before apply it, in @After reset
  • i

    itnoles

    11/28/2018, 4:10 AM
    do you have example?
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:12 AM
    FuelJsonTest
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:12 AM
    also RequestAndroidAsyncTest
  • i

    itnoles

    11/28/2018, 4:18 AM
    Found Two Tests and Made PR.
  • i

    itnoles

    11/28/2018, 4:25 AM
    it is interesting to put connection.doOutput = true inside of setBodyIfDoOutput and fail one test.
  • i

    itnoles

    11/28/2018, 4:27 AM
    @Derk-Jan Karrenbeld my PR passed.
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:28 AM
    sweeet
  • i

    itnoles

    11/28/2018, 4:29 AM
    it is ready to review.
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 4:30 AM
    Merged!
  • k

    kittinunf

    11/28/2018, 1:36 PM
    It looks like if we use the Kotlinx.serialization extension, user needs to add 
    maven { url "<https://kotlin.bintray.com/kotlinx>" }
    manually
  • k

    kittinunf

    11/28/2018, 1:36 PM
    one user reported me a problem
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 3:43 PM
    Correct. Open an issue and let's fix?
  • d

    Derk-Jan Karrenbeld

    11/28/2018, 7:03 PM
1...727374...118Latest