https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • d

    Derk-Jan Karrenbeld

    11/29/2018, 1:55 AM
    Yeah I've seen that too
  • d

    Derk-Jan Karrenbeld

    11/29/2018, 1:55 AM
    Since this is all under @kittinunf he's the only one who can answer the questions you two are asking
  • k

    kittinunf

    11/29/2018, 1:57 AM
    Morning!
  • k

    kittinunf

    11/29/2018, 1:58 AM
    What do you mean by can we even automatically add a repo for the users ?
  • k

    kittinunf

    11/29/2018, 1:59 AM
    Hmm, AndroidMaven is not used? Ah that's true, in the beginning, i thought we need it but it looks like we don't
  • i

    itnoles

    11/29/2018, 2:27 AM
    do we need samples to run in travis ci?
  • i

    itnoles

    11/29/2018, 2:31 AM
    @kittinunf ^
  • k

    kittinunf

    11/29/2018, 3:12 AM
    I don’t think we need to run sample there
  • k

    kittinunf

    11/29/2018, 3:12 AM
    do you think we should?
  • i

    itnoles

    11/29/2018, 3:13 AM
    not really
  • i

    itnoles

    11/29/2018, 3:35 AM
    PR passed.
  • d

    Derk-Jan Karrenbeld

    12/02/2018, 5:32 PM
  • i

    itnoles

    12/03/2018, 8:16 PM
    I could drop that PR and modify travis file for -x samples on test.
  • d

    Derk-Jan Karrenbeld

    12/03/2018, 8:28 PM
    That's maybe better?
  • i

    itnoles

    12/03/2018, 8:28 PM
    that would satified kittinunf opinions.
  • i

    itnoles

    12/03/2018, 9:23 PM
    nah, it wouldn't work
  • i

    itnoles

    12/03/2018, 9:43 PM
  • i

    itnoles

    12/04/2018, 4:22 AM
    @Derk-Jan Karrenbeld I found a way to exclude it from Travis CI
  • k

    kittinunf

    12/04/2018, 4:50 AM
    morning
  • k

    kittinunf

    12/04/2018, 4:50 AM
    yeah
    I could drop that PR and modify travis file for -x samples on test.
    Can we do that?
  • i

    itnoles

    12/04/2018, 4:52 AM
    ^ No
  • i

    itnoles

    12/04/2018, 4:52 AM
    -x only effect tasks, but not project.
  • i

    itnoles

    12/04/2018, 4:54 AM
    I created special gradle properties to exclude it or not.
  • i

    itnoles

    12/04/2018, 5:00 AM
  • k

    kittinunf

    12/04/2018, 5:05 AM
    does this work?
  • i

    itnoles

    12/04/2018, 5:07 AM
    Yes, you can look into the build log.
  • i

    itnoles

    12/04/2018, 5:08 AM
    I set gradle.properties for that properties to be true while on travis to false.
  • d

    Derk-Jan Karrenbeld

    12/04/2018, 7:10 AM
    This looks very clean to me
  • k

    kittinunf

    12/04/2018, 9:04 AM
    it is a 👍 for me
  • d

    Derk-Jan Karrenbeld

    12/04/2018, 3:34 PM
1...747576...118Latest