Channels
#kotlin-fuel
- d
Derk-Jan Karrenbeld
12/29/2018, 1:09 AMMy devices are android 9.0 - i
itnoles
12/29/2018, 1:10 AMHmm, I am doing HTTP Request in ViewModel - d
Derk-Jan Karrenbeld
12/29/2018, 1:10 AM(I'm assuming you use jitpack on master, right?) - i
itnoles
12/29/2018, 1:10 AMYes - i
itnoles
12/29/2018, 1:12 AMfuel-coroutines:master-SNAPSHOT - d
Derk-Jan Karrenbeld
12/29/2018, 1:12 AMIf you can, please provide a minimal reproducible sample, so we can debug this and "fix" if it needs fixing. The body is always consumed using
, but if you have a custom deserializer, that might be the issue.use - i
itnoles
12/29/2018, 1:13 AMOh okay, I will post my viewmodel class later - d
Derk-Jan Karrenbeld
12/29/2018, 1:14 AMSweet - i
itnoles
12/29/2018, 1:15 AMI did have to use Okio.source for BufferedSource - i
itnoles
12/29/2018, 1:15 AMMaybe it left dangling inputstream - d
Derk-Jan Karrenbeld
12/29/2018, 1:16 AMThe input stream should be flushed and closed, but if you use a custom body, that might be an issue - d
Derk-Jan Karrenbeld
12/29/2018, 1:16 AM(custom body != custom stream) - i
itnoles
12/31/2018, 3:16 AMJaCoCo Snapshot 0.8.3 will be huge code coverage gain for this project. - d
Derk-Jan Karrenbeld
12/31/2018, 3:28 AMsweet!! - i
itnoles
12/31/2018, 3:28 AMdo you want to use snapshot of it? - d
Derk-Jan Karrenbeld
12/31/2018, 3:29 AMDoes it take long for them to release? - i
itnoles
12/31/2018, 3:29 AMyes - d
Derk-Jan Karrenbeld
12/31/2018, 3:31 AMWip up a PR, let's see how good it is for us 😄 - i
itnoles
12/31/2018, 3:33 AMoh okay - i
itnoles
12/31/2018, 4:13 AMHmm, it actually decreased coverages. - d
Derk-Jan Karrenbeld
12/31/2018, 4:23 AMAs long as "my" code increased coverage 😛 - i
itnoles
12/31/2018, 4:23 AMyou can check 🙂 - d
Derk-Jan Karrenbeld
12/31/2018, 4:35 AM52 more hits and 36 more misses. This looks good to me! It seems to now track inlined calls? - i
itnoles
12/31/2018, 4:37 AMyes - i
itnoles
12/31/2018, 4:37 AMdid you see changes link? - i
itnoles
12/31/2018, 11:29 PMSome how Android 9.0 removed that "Did you forget to close a response body?" warning. It is very hard to detect which one is actually leaked. - d
Derk-Jan Karrenbeld
12/31/2018, 11:44 PMExsctly - d
Derk-Jan Karrenbeld
12/31/2018, 11:44 PMWe close it asynchronous, in a deserialiser - d
Derk-Jan Karrenbeld
12/31/2018, 11:44 PMI am certain it is closed - d
Derk-Jan Karrenbeld
12/31/2018, 11:44 PMOtherwise I could not make 500 simultaneous requests