https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • d

    Derk-Jan Karrenbeld

    01/12/2019, 11:31 PM
    Check out how we test some of the interactors. We create a new anonymous inline one, where we set a variable. The test then checks if the variable is set.
  • i

    itnoles

    01/12/2019, 11:31 PM
    anonymous inline is like object : Hook { }
  • i

    itnoles

    01/12/2019, 11:35 PM
    such as class PathStringConvertibleImpl(url: String) : RequestFactory.PathStringConvertible { override val path = url } ?
  • d

    Derk-Jan Karrenbeld

    01/13/2019, 3:17 AM
    Yes
  • i

    itnoles

    01/13/2019, 5:57 PM
    i did added Tests last night
  • d

    Derk-Jan Karrenbeld

    01/13/2019, 6:21 PM
    😄
  • i

    itnoles

    01/13/2019, 8:07 PM
    As for RequestExecutionOptions, could we change decodeContent and useHttpCache to true then dropped it from HttpClient?
  • d

    Derk-Jan Karrenbeld

    01/13/2019, 8:27 PM
    What do you mean?
  • i

    itnoles

    01/13/2019, 8:29 PM
    if we change decodeContent and useHttpCache to be true in RequestExecutionOptions, we don't need to set it on HttpClient
  • i

    itnoles

    01/13/2019, 8:44 PM
    I finally got gpg installed 🙂
  • d

    Derk-Jan Karrenbeld

    01/13/2019, 9:48 PM
    if we change decodeContent and useHttpCache to be true in RequestExecutionOptions, we don't need to set it on HttpClient
    ^ I still want it to be overwritable. If you want it 
    false
    by default, you basically have to change each and every request, right?
  • i

    itnoles

    01/13/2019, 11:48 PM
    right
  • i

    itnoles

    01/13/2019, 11:49 PM
    did we have it in readme that HttpCache is on by default?
  • d

    Derk-Jan Karrenbeld

    01/14/2019, 2:16 AM
    HttpCache
    only means that it is not sending with 
    Cache-Control: no-cache
  • i

    itnoles

    01/14/2019, 2:33 AM
    You have one test that modified httpcache on the request
  • i

    itnoles

    01/16/2019, 9:21 PM
    Kotlin 1.3.20 is coming
  • n

    Nikky

    01/17/2019, 2:39 AM
    i have a branch that worked for the last eap.. i should update it
  • n

    Nikky

    01/17/2019, 2:40 AM
    but it still works for using it with the newest eap
  • i

    itnoles

    01/17/2019, 11:37 PM
    Since my internet connection is really flaky, my time is really limited.
  • i

    itnoles

    01/20/2019, 2:11 AM
    @Nikky SSL is hard to support because Android SSL Support is bit odd
  • n

    Nikky

    01/20/2019, 5:03 AM
    I do not use fuel on android.. Yet
  • i

    itnoles

    01/20/2019, 5:49 AM
    TLS 1.2 is fully supported on Android 5+
  • n

    Nikky

    01/20/2019, 8:19 AM
    i still do not quite understand what you are responding to and why i was pinged, also was out and away from civilization yesterday
  • k

    kittinunf

    01/20/2019, 9:06 AM
    Kinda wanna release 2.0 … anyone has opinions on this?
  • n

    Nikky

    01/20/2019, 9:07 AM
    feels like 1.3.20 is just around the corner and with it come some changes to i think kotlinx-serialization that make it incompatible.. again
  • n

    Nikky

    01/20/2019, 9:08 AM
    want to wait for that or release and then make a quick follow up ?
  • k

    kittinunf

    01/20/2019, 10:38 AM
    ah that is good idea too
  • d

    Derk-Jan Karrenbeld

    01/20/2019, 12:41 PM
    Kinda wanna release 2.0 … anyone has opinions on this?
    Do it, with quick incremental releases soon after @kittinunf
  • i

    itnoles

    01/20/2019, 7:22 PM
    By reading to some reports, a lot of people are waiting on 2.0 releases
  • n

    Nikky

    01/20/2019, 10:18 PM
    i think a fast update afterwards would be better
1...818283...118Latest