https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • n

    Nikky

    01/24/2019, 11:47 AM
    one more change.. apparently serialization also updated finally (edit: why do i always mix up which kotlinx library updated?)
  • n

    Nikky

    01/24/2019, 11:52 AM
    no idea why but androix annotations needed to be backdated
  • n

    Nikky

    01/24/2019, 11:52 AM
    also because of android i guess i cannot use gradle 5+
  • n

    Nikky

    01/24/2019, 12:17 PM
    currently travis only complains because the linting task does not exist anymore
  • k

    kittinunf

    01/24/2019, 3:00 PM
    Checking the 
    Update_Kotlin_version
    branch
  • k

    kittinunf

    01/24/2019, 3:12 PM
    hmm I could not run the 
    build
    though
  • k

    kittinunf

    01/24/2019, 3:27 PM
    I will try to release v 2.0.0 then
  • k

    kittinunf

    01/24/2019, 3:28 PM
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:31 PM
    :3
  • k

    kittinunf

    01/24/2019, 3:39 PM
    hmm when i run test locally sometimes it fails though
  • k

    kittinunf

    01/24/2019, 3:39 PM
    but if i rerun them individually, it is okay
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:39 PM
    There might still be a mutability issue somewhere
  • k

    kittinunf

    01/24/2019, 3:39 PM
    it is possible that our mock server not in the correct state
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:39 PM
    (setting headers on the Fuel global instance, but not calling reset)
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:39 PM
    I don't think it's mocking
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:40 PM
    I think it's the global Fuel.instance
  • k

    kittinunf

    01/24/2019, 3:40 PM
    singleton problem
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:40 PM
    Yep 😄
  • k

    kittinunf

    01/24/2019, 3:40 PM
    yeah
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:40 PM
    I think the mock server is set-up to reset after each teast
  • k

    kittinunf

    01/24/2019, 3:40 PM
    shall we remove all the test for Fuel.instance then to make it more reliable?
  • k

    kittinunf

    01/24/2019, 3:41 PM
    maybe it might be a good time to say good bye to the singleton thingy too
  • k

    kittinunf

    01/24/2019, 3:41 PM
    (but it is really convenient to use)
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:42 PM
    I'd rather figure out which test is causing it 😛
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:42 PM
    So if a test fails, we should be able to tell why it fails and thus which actual call was the culprit
  • d

    Derk-Jan Karrenbeld

    01/24/2019, 3:42 PM
    As long as for right now your tests run correctly individually and you do get green runs we can merge and fix later btw
  • k

    kittinunf

    01/24/2019, 3:45 PM
    oh oh … .
  • k

    kittinunf

    01/24/2019, 3:45 PM
    Copy code
    java.lang.NoSuchFieldError: LONG_STRING_TEMPLATE_ENTRY
  • k

    kittinunf

    01/24/2019, 3:46 PM
  • k

    kittinunf

    01/24/2019, 3:46 PM
    oh this guy looks familiar xD
1...838485...118Latest