so you don't have to write that 🙂

and Fuel gives me statusCode -1

logger.error("invalid statusCode {} from {}", response.statusCode, url.encoded)
                logger.error("connection url: ${request.url}")
                logger.error("cUrl: ${request.cUrlString()}")
                logger.error("response: $response")
                logger.error("error: {}", result.error.toString())
                logger.error(result.error.exception) { "Download Failed" }

gives me this output:

invalid statusCode -1 from <http://files.mcupdater.com/MCU-FastPack-latest.jar>
connection url: <http://files.mcupdater.com/MCU-FastPack-latest.jar>
cUrl: curl -i -H "If-None-Match:"10f43e5-5802152ceb7c1"" <http://files.mcupdater.com/MCU-FastPack-latest.jar>
response: <-- -1 http://.
Response : 
Length : 0
Body : (empty)
Headers : (0)

error: com.github.kittinunf.fuel.core.BubbleFuelError: HTTP Exception 304 Not Modified
com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.k:84)
com.github.kittinunf.fuel.core.FuelError$Companion.wrap$default(FuelError.kt:83)	com.github.kittinunf.fuel.core.DeserializableKt$awaitResponseResult$3.invoke(Deserializable.kt:252)	com.github.kittinunf.fuel.core.DeserializableKt$awaitResponseResult$3.invoke(Deserializable.kt)
com.github.kittinunf.result.ResultKt.mapError(Result.kt:42)
com.github.kittinunf.fuel.core.DeserializableKt.awaitResponseResult(Deserializable.kt:252)

statusCode is -1 but the exception says 304 not modified

and what response prints also looks weird

Well you can tell what happens

you get 304, but it tries to deserialize. This is actually an issue with the deserializer

You should temporarily implement your own that checks for 304 first

ohh i see

or could be just fix the serializers to pass through the original error code ?

btw what i am doing is

awaitByteArrayResponseResult

i tried this:

awaitResponseResult(object: Deserializable<ByteArray> {
                val original = ByteArrayDeserializer()
                override fun deserialize(response: Response): ByteArray {
                    println("deserializer statusCode: ${response.statusCode}")
                    return when {
                        response.statusCode == 304 -> cacheFile.readBytes()
                        else -> original.deserialize(response)
                    }
                }
            })

the code does not even run, i guess because the response body is empty

You can try a custom ResponseDeserializer

Oh that's what you are trying 😛

com.github.kittinunf.fuel.core.DeserializableKt$awaitResponseResult$3.invoke(Deserializable.kt)

that errored here before

i just noticed.. i install a redirectResponseInterceptor.. cna that somehow modify the output of cUrlString() to add

-L

?

atm the output of

request.cUrlString()

is not quite accurate

and i just got a bug report from someone where one webserver responds fien with 200 and then the stream closes during file download

fun

Ok so we are releasing 2.0.1

haha that was really quick

anything we want to add for 2.0.1 small bug fixes and stuffs?

looking back at 2.0.0 maybe a 2.0.0-alpha would have been the right choice for such a huge jump ?

Next time 😛

I’m writing a plugin that uses Fuel. Attempting to use this plugin in other projects causes the error

Could not find org.jetbrains.kotlinx:kotlinx-serialization-runtime:0.9.1.

.

you can either make it a fat-jar with shadowjar or you have to add the kotlinx repo on your consumers

Don't release 2.0.1

Kotlin Corountines 1.1.1 for compaion releases of Kotlin 1.3.20

oh.. another update.. should i do that too and see what changed ?