https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • b

    bmsantos

    12/16/2015, 2:56 PM
    Coalesce.java
    Coalesce.java
  • b

    bmsantos

    12/16/2015, 2:58 PM
    I ended-up doing it in the above way,
  • b

    bmsantos

    12/16/2015, 2:58 PM
    But it smells like Fuel should have support for it.
  • k

    kittinunf

    12/16/2015, 5:01 PM
    @bmsantos: Thanks. Those compliments are exuberant.
  • b

    bmsantos

    12/16/2015, 5:04 PM
    With so much clutter out there, its nice to see a library that is well designed and a pleasure to work with.
  • k

    kittinunf

    12/16/2015, 5:06 PM
    Regarding to your comment about synchronity (not sure that is the word), we made 
    executor
    as 
    public
    by design.
  • k

    kittinunf

    12/16/2015, 5:07 PM
    Could you try to provide the synchronous version and plug it in? Sth like 
    Manager.instance.executor = ….
  • b

    bmsantos

    12/16/2015, 5:08 PM
    And that’s great since one might want to tweak the executor. Like I did in the above the code example.
  • k

    kittinunf

    12/16/2015, 5:08 PM
    Oh I just saw your snippet. Yes. that is exactly that
  • k

    kittinunf

    12/16/2015, 5:08 PM
    yeah I know it is not the ideal.
  • k

    kittinunf

    12/16/2015, 5:10 PM
    But I just do not want to promote to call it in a synchronous way.
  • k

    kittinunf

    12/16/2015, 5:11 PM
    Also I don’t yet find an elegant way to support both versions, so it ended up being easy with async, and a little harder (but possible) with the sync.
  • b

    bmsantos

    12/16/2015, 5:12 PM
    But, and this is the question, shouldn’t Fuel provide a couple of methods to do that? something like what I did (basic case) :
    Copy code
    Manager.Companion.coalesce()
    And something else that might allow the re-initialization of a desired Executor:
    Copy code
    Manager.Companion.coalesce(executor:Executor)
  • b

    bmsantos

    12/16/2015, 5:14 PM
    Ideally you would have something like:
    Copy code
    "posts/${postId}".httpPut().body(post.json()).responseString { request, response, either ->
        if (either is Either.Right) result = either.right
    } .coalesce()
  • b

    bmsantos

    12/16/2015, 5:16 PM
    Just food for thought!
  • k

    kittinunf

    12/16/2015, 5:18 PM
    Yeah gotta say that is not bad at all
  • k

    kittinunf

    12/16/2015, 5:27 PM
    Btw, once we call the 
    coalesce()
    , all 
    Fuel
    calls onward will be effected as well right?
  • b

    bmsantos

    12/16/2015, 5:29 PM
    coalesce waits for all threads to stop, so its safe
  • b

    bmsantos

    12/16/2015, 5:30 PM
    but if you can wait for the respective thread, it will be even better
  • k

    kittinunf

    12/16/2015, 5:31 PM
    after yes, I guess my mind is leaning towards async/sync for each call.
  • b

    bmsantos

    12/16/2015, 5:31 PM
    that would be great.
  • k

    kittinunf

    12/16/2015, 5:32 PM
    we need to define it with interface I guess.
  • k

    kittinunf

    12/16/2015, 5:32 PM
    if client provides 
    lambda
    , we inherently use the 
    async
    version.
  • k

    kittinunf

    12/16/2015, 5:33 PM
    perhaps, the 
    sync
    version is just a plain return object
  • b

    bmsantos

    12/16/2015, 5:33 PM
    true
  • k

    kittinunf

    12/16/2015, 5:35 PM
    Copy code
    val call = "posts/${postId}".httpPut().body(post.json()).responseString()

//synchronous
call.request = ...
call.response = ... 
call.either = ...
  • k

    kittinunf

    12/16/2015, 5:40 PM
    Seem to be a workable solution, thanks @bmsantos for the insight. simple smile Just wanna say that PR is also welcome if you feel you want to do it.
  • b

    bmsantos

    12/16/2015, 5:41 PM
    Thanks
  • g

    geetha.gubendran

    12/20/2015, 2:12 AM
    I am using kotlin fuel to do network calls and to parse JSON easily, I use responseJson
  • g

    geetha.gubendran

    12/20/2015, 2:13 AM
    I want to know how to get the error code thrown by the call like 404, 502 etc
1...8910...118Latest