i think that would be helpful.. so that the correct people get notified when the subproject of fuel they are working on mostly or maintaining gets a PR

yes we use this at my company for certain sections of code.

who going to be "code owners?"

well i would be fine with doing the coroutines and/or serialization stuff, if only to not miss any changes to the code there, its what i use most often

you are the most experienced guy on those stuffs

including

build.gradle.kts

too

Should we dump Travis CI over their acquisitions with Idera?

@kittinunf should we uses CircleCI now?

the only thing I am too lazy to do is to migrate the CI config

@itnoles I found out that

stetho

extension only works for the first request

I will open a PR to fix this

I wanna announce a rule if anyone mentioned the native Result, i will give them 😾 icon

https://github.com/kittinunf/fuel/pull/602 ready to merge?

I need to fix the redirect request first … don’t have time to look on that yet

I promise it will be done within this week

circleci has weird configuration for cache. According to the example of it, it wants checksum on EACH folders for build.gradle 😞

Is there are prettier way to do this? (blocking)

apiRequests.forEach {
        val result = <http://Fuel.post|Fuel.post>(Config.API_ENDPOINT)
                .jsonBody(jackson.writeValueAsString(it))
                .responseString()
        if(!result.second.isSuccessful) {
            failedApiRequests.add(it)
            println(result.second.responseMessage)
        }
    }

Are you trying to get all failed called, and block whilst a call is going on? Something like this is equivalent I think:

val failedApiRequests = apiRequests.mapNotNull { 
  val (_, response) = <http://Fuel.post|Fuel.post>(Config.API_ENDPOINT).jsonBody(jackson.writeValueAsString(it)).responseString()
  if (response.isSuccessful) null else it.also { println(response.responseMessage) }
}

And if you use RxJava, you can use the RxJava extension to make it nicer …

Thanks!

https://github.com/JetBrains/inspection-plugin Would this plugin to useful to use IDEA inspections on Gradle without having to run Intellij IDEA?

@Derk-Jan Karrenbeld I am wondering that he hits the slow path operations on Android.

Travis CI is not very good anymore

I will fix some small things here and there and move to Gradle 5.2

Also will use

implementation

over

compile

where it is appropriate

It should also fix the unintentional usage of the

org.json

dependency

i think for stuff like fuel-coroutines it makes sense to keep it as a api dependency

because then it will actually expose that dependency and projects using it don't have to guess which version is compatible and which dependencies are required

and it can still be overridden by consumers

looks like I need to add whitespace on my repo to trigger circleci builds.