https://kotlinlang.org logo
Channels
Powered by
#kotlin-fuel
  • k

    kittinunf

    04/30/2019, 2:37 AM
    Thanks!!
  • i

    itnoles

    04/30/2019, 2:39 AM
    should we make fuel and fuel-test to be published to maven?
  • i

    itnoles

    04/30/2019, 2:39 AM
    since fuel one is just a core
  • k

    kittinunf

    04/30/2019, 2:39 AM
    test?
  • k

    kittinunf

    04/30/2019, 2:39 AM
    maybe no?
  • i

    itnoles

    04/30/2019, 2:41 AM
  • k

    kittinunf

    04/30/2019, 4:23 AM
    oh it looks like we publish it now
  • k

    kittinunf

    04/30/2019, 4:23 AM
    😅
    🤪 1
  • k

    kittinunf

    04/30/2019, 11:37 AM
  • k

    kittinunf

    04/30/2019, 11:58 AM
    I have a request from user for Moshi support so I am thinking about releasing new version soonish
  • k

    kittinunf

    04/30/2019, 11:59 AM
    if any of you have a bit of spare time, please also give 💌 for the PRs 🙏
    ❤️ 1
  • i

    itnoles

    05/01/2019, 7:27 PM
    I see what you mean for
    Copy code
    public final T fromJson(okio.BufferedSource source)
                                              throws IOException
  • i

    itnoles

    05/01/2019, 7:30 PM
    Kotlin 1.3 has inline class may be useful for ResponseDeserializable
  • k

    kittinunf

    05/02/2019, 11:21 AM
    Oh, please share it in the PR!
  • k

    kittinunf

    05/02/2019, 12:39 PM
    🙏
  • k

    kittinunf

    05/02/2019, 1:08 PM
    It looks like trying to discover the real exception on 
    BubbleFuelError
    is a bit of a challenge?
  • k

    kittinunf

    05/02/2019, 1:08 PM
    Can we do something about this?
  • i

    itnoles

    05/02/2019, 10:41 PM
    Inline Class only work on ONE parameters.
  • d

    Derk-Jan Karrenbeld

    05/03/2019, 12:06 AM
    Yeah we can -- but bubble: null should not happen 😕
  • d

    Derk-Jan Karrenbeld

    05/03/2019, 12:06 AM
    So I don't know what's going wrong
  • i

    itnoles

    05/03/2019, 1:52 AM
    @Derk-Jan Karrenbeld if we can reproduce it, we could set breakpoint or do debugging log.
  • i

    itnoles

    05/03/2019, 1:57 AM
    Android could have to swallow some execeptions.
  • i

    itnoles

    05/03/2019, 1:58 AM
    oh wait, that is in Log.
  • i

    itnoles

    05/03/2019, 2:31 AM
    FuelError is making it too complicated with coroutines and non-coroutines.
  • i

    itnoles

    05/03/2019, 2:53 AM
    after all, HttpUrlConnection is very legacy HTTP Clients.
  • k

    kittinunf

    05/03/2019, 1:34 PM
    I think the root cause of the problem in the issue is 
    NetworkOnMainThreadException
  • k

    kittinunf

    05/03/2019, 1:34 PM
    Let me try to see what we can do for this
  • d

    Derk-Jan Karrenbeld

    05/03/2019, 2:17 PM
    I think the reasoning here was: we lazy read the error message! We don't want to keep wasting data/resources there; so the error message is lazy, but then they read the rror message sync.
  • d

    Derk-Jan Karrenbeld

    05/03/2019, 2:17 PM
    Perhaps creating a method that gets the error message as a callback would already solve it
  • i

    itnoles

    05/03/2019, 2:20 PM
    Hmm, nobody responded back.
1...979899...118Latest