https://kotlinlang.org logo
Channels
Powered by
#kotlintest-devs
  • l

    LeoColman

    05/28/2019, 12:56 AM
    Ah, I see
  • l

    LeoColman

    05/28/2019, 12:56 AM
    We have a try catch there, yes
  • l

    LeoColman

    05/28/2019, 12:56 AM
    But 
    coroutines.join()
    won't propagate the exception
  • l

    LeoColman

    05/28/2019, 12:56 AM
    That's the start of the issue
  • s

    sam

    05/28/2019, 12:56 AM
    ah
  • l

    LeoColman

    05/28/2019, 12:56 AM
    When I fixed that, 
    gradle
    was errorring correctly
  • s

    sam

    05/28/2019, 12:56 AM
    what happens if there is an error inside a coroutine - the parent coroutine will get the error
  • s

    sam

    05/28/2019, 12:57 AM
    so why doesn't .join throw
  • s

    sam

    05/28/2019, 12:57 AM
    is it using async ?
  • l

    LeoColman

    05/28/2019, 12:57 AM
    However JUnit and our executor won't error correctly.
  • l

    LeoColman

    05/28/2019, 12:57 AM
    I transformed it to use async, yes
  • l

    LeoColman

    05/28/2019, 12:57 AM
    Let me commit what I have atm, in a second
  • s

    sam

    05/28/2019, 12:57 AM
    async won't throw any errors
  • l

    LeoColman

    05/28/2019, 12:57 AM
    It does when you 
    await
  • s

    sam

    05/28/2019, 12:57 AM
    yes
  • s

    sam

    05/28/2019, 12:57 AM
    you have to call .await to see the error
  • l

    LeoColman

    05/28/2019, 12:57 AM
    yep
  • l

    LeoColman

    05/28/2019, 12:57 AM
    I did that
  • l

    LeoColman

    05/28/2019, 12:58 AM
    And it started erroring correctly, but only for 
    gradlew test
  • l

    LeoColman

    05/28/2019, 12:58 AM
    For running with JUnit and our plugin, the error won't show up in the IDE
  • l

    LeoColman

    05/28/2019, 12:58 AM
    The Spec error isn't being propagated to the runner
  • l

    LeoColman

    05/28/2019, 12:58 AM
    And I kinda got stuck there for a minute. I'll resume tomorrow
  • l

    LeoColman

    05/28/2019, 12:58 AM
    I'll commit what I have atm in a moment
  • l

    LeoColman

    05/28/2019, 12:59 AM
    And you can take a look if you have time, and if you have any insights xD
  • s

    sam

    05/28/2019, 1:00 AM
    ok
  • s

    sam

    05/28/2019, 1:00 AM
    Every time we see another error it makes me want to ditch junit more and more
  • s

    sam

    05/28/2019, 1:00 AM
    Gradle still not done any work on junit5 fixes
  • l

    LeoColman

    05/28/2019, 1:24 AM
    I think this one is our fault
  • l

    LeoColman

    05/28/2019, 1:24 AM
    We're not sending any error to JUnit
  • l

    LeoColman

    05/28/2019, 1:24 AM
    That's why it's not registering an error
1...131415...83Latest