How do people set up ktlint in their Android development team workflows? My issue is that we now have ktlint added to my teams Android project, but everyone on my team loves to press cmd + shift + L (reformat code) and everyone uses like a slightly different version of intellij/Android Studio and so cmd shift L is always kind of messing things up. What's the best way to setup ktlint so that we always stay in sync? I know I've mentioned a few times above that I'm new at all of this code style/formatting (it's my first real team project) and so I'm lost to what the conventions are as to how to set this up.

According to https://github.com/pinterest/ktlint/issues/701 it sounds like intellij idea integration is imperfect.

I am proposing to deprecate current IntellijIDEA integration. Problem with it:

- writes IDEA specific configuration xml files that could not be used by other editors

- is detached from used rules and not configurable. Only generic style is written to configuration file.

The project readme makes it seem like it is perfect?

. with IntelliJ IDEA

While this is not strictly necessary it makes Intellij IDEA's built-in formatter produce 100% ktlint-compatible code

Worth opening up a bug about the README, or am I misinterpreting something.

In progress of moving to ktlint but trying to ensure open PRs are based off latest master that contains new formatting hooks - is there a quick way to determine if ktlint has been run over a set of files? Doing a single reformat but typically have ~30 PRs merged per day so some chance for unformatted ones to slip through (require keep branches up to date is a different challenge) In my head an idea looks a bit like

./ktlint check <git-commit-range>

and returns back an exit code of 0/1 based on the files in the diff. Maybe somebody has a better way for handling this? Or a solution already exist I’m unaware 🤔 Incremental would be great to minimize build impact, running with --format takes ~25 sec. If it was fast enough would consider just leaving it in to catch environments that haven’t set up hooks yet and post a comment on the PR

Hello. I am using the

gradle ktlintCheck

command in Gitlab-CI, which returns some irregularities to me. I fix them and restart CI - again I get linter errors. Can something be done to get linter to display all the irregularities the first time? It is a bit tiring when linter returns warnings in batches.

Hi there. I am wondering if ktlint should / will support kotlin 1.4.

I'm fighting against ktlint and android studio right now (AS 4.0.0, ktlint 0.37.1) Android studio always formats the code like this:

import java.time.LocalDate
import java.time.temporal.ChronoUnit

fun test() {
  val lastActive = LocalDate.now()
  if (lastActive != null && ChronoUnit.DAYS.between(
      lastActive,
      LocalDate.now()
    ) > 30
  ) {
    println("hello")
  }
}

And then ktlint complains because it wants to have two less spaces before the argument

ChronoUnit.DAYS.between

Can someone confirm this?

Is there anything in ktlint which checks if a developer has mention the variable names in comments?

i.e. create_foo(/* fooParam= */ 1, ...)

Where ktlint should only throw an error for constants.

Would it be possible to write a rule which would fail if a certain method was used? We're trying to look at prevent use of

ExecutorService.submit

(and friends) in favor of our own

safeSubmit

since

submit

swallows all exceptions by default.

Hi all. I know that Klint is for style & formatting but since you can access PSI elements, I am wondering is it possible to write a rule which would fail if not certain class is extended. Would it be possible to do that in Ktlint?

New ktlint-gradle plugin release `9.3.0`: https://github.com/JLLeitschuh/ktlint-gradle/blob/v9.3.0/CHANGELOG.md#930---20200717 Most valuable - new Gradle configuration cache support

hey folks! have been a long since I didnt ask and help anyone here (and I apologize for that) but I have a question, if anyone can help me: There is a way to run a pre commit hook with ktlintFormat instead ktlint? or both? I tried to modificate the original pre commit hook installed by CLI, changing

ktlint

to

ktlintFormat

but doesnt work and I got this error

xargs: ktlintFormat: No such file or directory

Hi there I have question regarding rules that ktlint applyToIDEA actually change in IntelliJ can I get them as editorconfig file(this is most efficient way to keep same guide for a team)?

There is a way to inspect what is difference between using ktlint with

--android

and without on a Android kotlin code

Is there a list of all the rule names? I’ve been searching and can’t find one. I’m looking for the rule names in the

no-wildcard-imports

format that I can use to disable certain rules.

Hey there! I had a question about how to share custom rules. For example, if I published a project with a custom RuleSetProvider to maven, should I "just" be able to add a dependency to that project, and then add my rule to the

src/main/resources/META-INF/services/com.pinterest.ktlint.core.RuleSetProvider

file? Would appreciate if there were any recipes I could be pointed to! 🙂

Hey folks! Just released an alpha version of an IntelliJ / Android Studio plugin for ktlint: https://plugins.jetbrains.com/plugin/15057 https://github.com/nbadal/ktlint-intellij-plugin At first, it just adds annotations based on the standard + experimental rule sets, but I’ve got a list of TODO’s in the repo to tackle to get it up to parity with the command line tool as soon as possible 😄

Is there a way to require new lines & trailing commas for any parameter list with >= 3 params?

With ktlint and spotless when would be the best time to hook in and run spotlessApply?

Cross posting this from the gradle slack because it’s sepcifically the ktlint plugin that’s giving me the issue. I’ve been using this gradle task to try and make my build runnable with no network connection:

fun Configuration.isDeprecated() = this is DeprecatableConfiguration && resolutionAlternatives != null

tasks.register("downloadDependencies") {
  doLast {
    configurations
      .filter { it.isCanBeResolved && !it.isDeprecated() }
      .forEach { it.resolve() }
  }
}

Idea is I run that task with a network connection, then go offline to run the actual build to prove my build will now run without a network connection. However, using the 

org.jlleitschuh.gradle.ktlint

 plugin I’m still getting a failure running the offline build on a clean box when it tries to download 

ktlint:0.36.0

(I’m setting the version explicitly to

0.39.0

). Does the plugin contribute its dependencies to a configuration that I could resolve up front?

Hello!! I would like to use the snapshot so ktlint can work with new

fun interfaces

like I found here. So I added the maven repository

maven { url "<https://oss.sonatype.org/content/repositories/snapshots>" }

and changed the version to:

ktlint {
    version = "1.4-M2-kotlin-dev-SNAPSHOT"
}

is the version correct? thanks in advance 🙂

Hi, I tried

./ktlint -F app/src/**/*.kt

from my Android project root directory. All works and it corrected the file format. However it is not following AndroidStudio default rule. So I tried

./ktlint --android applyToIDEA -F app/src/**/*.kt

, but it crashes as below.

Exception in thread "main" picocli.CommandLine$UnmatchedArgumentException: Unknown options: -F, app/src/androidTest/java/com/example/pdfreader/ExampleInstrumentedTest.kt, app/src/main/java/com/example/pdfreader/FileDownloader.kt, app/src/main/java/com/example/pdfreader/MainActivity.kt, app/src/main/java/com/example/pdfreader/PageAdaptor.kt, app/src/main/java/com/example/pdfreader/PageHolder.kt, app/src/main/java/com/example/pdfreader/PdfReader.kt, app/src/test/java/com/example/pdfreader/ExampleUnitTest.kt
	at picocli.CommandLine$Interpreter.parse(CommandLine.java:7283)
	at picocli.CommandLine$Interpreter.processArguments(CommandLine.java:7357)
	at picocli.CommandLine$Interpreter.parse(CommandLine.java:7257)
	at picocli.CommandLine$Interpreter.parse(CommandLine.java:7147)
	at picocli.CommandLine.parseArgs(CommandLine.java:836)
	at com.pinterest.ktlint.Main.main(Main.kt:55)

What did I do wrong? I tried remove the

-F

, it is not working as well? I think I might have miss something…. any help? 🙏

Updated from org.jlleitschuh.gradle:ktlint-gradle:9.2.1 to 9.4.0 and now I'm getting hundreds of these kinds of errors

filea.kt:266:21: Unexpected indentation (expected 16, actual 20)
fileb.kt:267:17: Unexpected indentation (expected 12, actual 16)
filec.kt:281:21: Unexpected indentation (expected 16, actual 20)
filed.kt:282:17: Unexpected indentation (expected 12, actual 16)

What's the easiest way to resolve all of these? I'm assuming it either Opt out or Auto format via

./gradlew ktlintFormat

or intellij? Note: I'm using editorConfig (Not sure if that changes things) I tried auto formatting view ktlint and via intellij to no avail. Am I missing something?

Hi there! I update to 0.39.0 and while running

ktlint

it tells me that the following

import

is not being used therefore I should remove it:

import org.mockito.Mockito.`when` as _when --- THIS LINE IS THE PROBLEM

@Before
@CallSuper
override fun setup() {
    super.setup()

    _when(...).thenReturn(...)
}

is this a known issue?

we have ktlintformat that we have it in each module. it is super annoying to run the Gradle command individually in each module every time you create PR. ./gradlew ktlintformat. : I wanna get off this 😎

Hi.. is it somehow possible to configure ktlint with

kotlin_imports_layout

to allow idea and ascii import ordering (so not the whole repo needs to change it’s order but we can still use the idea built in import order)?

Does ktlint has a baseline file like detekt? I want to enable ktlint on an existing project and check only new problems.

Is it possible to configure ktlint with CI so it runs only for changed files?

ran it from cmd (simple ktlint in the offending folder), got a related warning:

TextInputLayoutMatchers.kt:3:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

funny, spotless didnt report the numerous other warnings eg

unexpected indentation (28) (should be 24)
Missing newline before ")"
etc

This message was deleted.