I am having a weird issue when running ktlint locally (using the gradle plugin) where check and format do not line up

daz@daz:/source/source/well/consumer-android-ui-2$ git status
On branch MOB-310-integrate-ktlint
Your branch is up to date with 'origin/MOB-310-integrate-ktlint'.

nothing to commit, working tree clean
daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetCheck
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 919ms
16 actionable tasks: 1 executed, 15 up-to-date
(failed reverse-i-search)`forma': git reset --hard origin/MOB-1190-calculate-height-^Cr-list-items
daz@daz:/source/source/well/consumer-android-ui-2$ ./gradlew :app:ktlintDebugSourceSetFormat
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 1s
16 actionable tasks: 2 executed, 14 up-to-date
daz@daz:/source/source/well/consumer-android-ui-2$ git status
On branch MOB-310-integrate-ktlint
Your branch is up to date with 'origin/MOB-310-integrate-ktlint'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   app/src/debug/java/co/foo/data/session/LocalSessionDataSource.kt
        modified:   app/src/debug/java/co/foo/util/FlipperUtil.kt

no changes added to commit (use "git add" and/or "git commit -a")

Hello team! Why have you slowed down to merge new PRs? 🙂 What is your plan for the existing PRs and new version?

Informal poll - do you prefer configuring lint/formatting definitions in the Intellij IDE or using .editorconfig? Is one better suited to align with ktlint rules/formatting?

no matter what I try, I can't get the Android Studio formatter to format files the same way ktlintFormat works

Hey guys, Do you have any lint rules to check,

when setting up our modules & their corresponding dependencies I think we should have a rule that we always need to add a classifier declaration. This makes things crystal clear when we revisit the modules. So for example instead of

viewModel { ConsultationViewModel(networkSessionScope.get(), get()) }

we would have

viewModel { ConsultationViewModel(addressRepository = networkSessionScope.get(), consultationsRepository = get()) }

Just makes the solution more readable. I just want to check only specific file, not in whole project

I have a custom rule that I want to run on a gradle module however it should run on the main sourceset only, not on the test sourceset, i.e. tests should be excluded from my rule. Does anyone know how I can do this with org.jlleitschuh.gradle.ktlint gradle extension, or some other way?

Second question, when I am developing a custom rule, if I make changes to the rule then run

ktlintMainSourceSetCheck

the old version of the rule is used. The compiled custom rule is cached somewhere but I can’t work out how to remove it

I'm looking at updating a project from ktlint 1.10.2 to 1.13.1, and I see that it wants to change an indentation:

val snapshot: Snapshot
         get() {
             val bucketCounts = Array(thresholdCounts.size) {
-                i ->
+                    i ->
                 Pair(Pair(thresholds[i], thresholds[i + 1]), thresholdCounts[i].sum())
             }

Why is it better to have the variable indented like that? It seems odd to me.

Hello, after the latest snapshot, I am getting this

Execution failed for task ':data:runKtlintFormatOverKotlinScripts'.
> A failure occurred while executing org.jlleitschuh.gradle.ktlint.worker.KtLintWorkAction
   > com/pinterest/ktlint/core/KtLint$Params

Stacktrace in the thread

Hi everyone I am checking my compose UI with ktlint but I am having this issue `...\app\src\main\java\com\...\app\ui\theme\Theme.kt:33:29`: Not a valid Kotlin file (type expected) (cannot be auto-corrected) Line points to

() -> Unit

in nested function Theme.kt:

@Composable
fun MusicApp_theme(
    darkTheme: Boolean = isSystemInDarkTheme(),
    content: @Composable () -> Unit
) {
    val colors = if (darkTheme) {
        DarkColorPalette
    } else {
        LightColorPalette
    }

    MaterialTheme(
        colors = colors,
        typography = Typography,
        shapes = Shapes,
        content = content
    )
}

In this version we switched to the new 2K compiler. This forces API consumers to use that compiler as well. As that is unintended and unwanted, a new minor version is to be expected in a couple of days. See https://github.com/pinterest/ktlint/pull/1506

Hi all, I’m looking into making a custom ktlint rule that enforces named arguments everywhere. How would I go about doing something like this where I need to have context from the code being linted, ie the names of the arguments? or is this not possible?

Hi all, ktlint 0.46.1 has been released. This is a minor release intended to address some regressions introduced in 0.46.0, including reverting the change to use the new K2 compiler. See https://github.com/pinterest/ktlint/releases/tag/0.46.1

Getting an issue when trying to switch to 0.46.1, not sure if the problem is with ktlint-gradle (

org.jlleitschuh.gradle.ktlint

) or ktlint itself?

java.lang.NoClassDefFoundError: com/pinterest/ktlint/core/KtLint$Params
        at org.jlleitschuh.gradle.ktlint.worker.KtLintWorkAction.execute(KtLintWorkAction.kt:52)

Most likely a problem in the ktlint-gradle. 0.46.x of ktlint contains breaking changes which needs to be incorporated in the plugin.

Thanks, seems to be reported as well https://github.com/JLLeitschuh/ktlint-gradle/issues/589

I am not that hopeful it’ll likely to be addressed in

ktlint-gradle

side. I have already started to look for other plugins. Some of them; kotlinter and diktat

We are planning to do an upgrade of kotlinter to 0.46.1. As there are API changes, it will require a little extra time. Thanks ahead for the patience 🙏.

Hi all, Please contribute to the discussion Drop requirement that code formatted by Ktlint is compatible with IntelliJ IDEA default formatting . Please do not start discussing in this thread as we might loose oversight when having parallel discussions.

Finally got around to updating ktlint-intellij-plugin to 0.46.1, hopefully I didn't miss anything in the upgrade! 🤞 ExperimentalParams + editorConfigOverride instead of userdata https://github.com/nbadal/ktlint-intellij-plugin/commit/c4abbb7b42e18f08858a2fb86a641a66f12513e6

If you have custom rules for the intellij ktlint plugin, and they don't seem to run after you put the jar files in the ktlint ide plugin config form, is there any way to debug why? There are no errors in the AS IDE log either 🤔 Side note: would be nice if the jar list field were larger because the jar paths can be fairly long if you have multiple jars.

Is there any issue with running ktlint-grade on an

com.android.library

module? I’ve got a simple module which is setup to be a com.android.library and also applies this ktlint setup. However in the end, in the files that are contained in this core-common module things do not get formatted at all.

:core-common:ktlintCheck

doesn’t find an error and ktlintFormat doesn’t edit them at all either. It’s weird because I do the exact same setup on my app module which is a com.android.application instead and it works perfectly fine. I’ve also tried stuff like applying the plugin only to that one module but still nothing, it only works on my application module. If anyone else who’s using the plugin in a multi-module setup like this has any ideas I would really appreciate it. (.editorconfig used is here and I am using ktlint gradle plugin 10.3.0 with ktlint “0.45.2”)

I wish the trailing-comma rule defaulted to adding a redundant trailing comma. It makes it easier to add items later on, and such changes only shows a diff on the actual changed line. Basically just benefits of having the comma there. 🙂

Exceeded max line length (120) (cannot be auto-corrected) (max-line-length)

Why can't line length be auto-corrected? IntelliJ auto-corrects it just fine. Any alternative settings or different tools that can do better?

The KtLint documentation has been revamped. Please check out https://pinterest.github.io/ktlint/ If you find inconsistencies, dead links or have suggestions for improvement, please report an issue.

I feel like I must be missing some part of the documentation, so if someone can point me there that’d be great, but how does one use the CLI and let ktlint know that there is a .editorconfig to be respected (for trailing commas in my use case)?

Ktlint (or the Gradle plugin) just started behaving weird in my project without any changes in its version or config, see https://github.com/krzema12/github-actions-kotlin-dsl/issues/382. In our project we generate some Kotlin files with Kotlin Poet and then pass it through ktlint. Our job that periodically checks if the generated files need updating, started failing on differences in formatting, as if certain kinds of wrong formatting wasn't fixed now. It was working fine yesterday or so. Super-weird because I didn't change any ktlint-related version... Is some updating going on behind the scenes? Is it only me?

KtLint does not magically update behind the scenes. If the version and configuration are unchanged since last successful run than the difference must be in the code. I am not familiar enough with the plugin to say something about it.

Possibly false negative from

spacing-between-declarations-with-annotations

? 🧵