I am not sure about transformations in ktor but am I right that it is not possible to retrieve a ValuesMap for an empty post body (with missing content-type also)

It seems that this would fail when looking at https://github.com/Kotlin/ktor/blame/master/ktor-hosts/ktor-hosts-common/src/org/jetbrains/ktor/host/DefaultTransform.kt

yes, there is no body, how would you receive anything?

I want an empty ValuesMap, not an exception

I expect that is what most other frameworks do also

But it could be an edge case

If one were to err on the safe side then maybe missing content type and empty body when receiving a ValuesMap should result in an empty ValuesMap

Use

tryReceive

then

It’s basically just this: https://github.com/Kotlin/ktor/blob/master/ktor-core/src/org/jetbrains/ktor/request/ApplicationReceiveFunctions.kt#L22

need to rename to

receiveOrNull

to be in line with stdlib, though

Yes I saw that also 🙂

But in general terms I somehow feel this violates the principle of least surprise. At least for our usecase.

It seems that jquery will not add the content type on a POST with an empty data object, but otherwise will

I believe it’s a general practice in Kotlin to return non-nullable value by default, and if applicable, have an

xxxOrNull

function

Sure, but I am specifically talking about receiving ValuesMap here

The current behavior is probably expected for other content types and transformations

How would framework know that missing content-type is indeed an empty map, and not some kind of BadRequest?

inline suspend fun ApplicationCall.receiveParameters(): ValuesMap = receive()

may be we need to change this to

receiveOrNull() ?: ValuesMap.empty

Yes. That is all I am saying

but well, no… as it currently works, it will return empty when content type is app/json

Or maybe a

null

branch in DefaultTransform.kt ?

Please file an issue, we’ll think about it

For now you can use your own

receiveParametersOrEmpty

function 🙂

I will investigate a bit more before doing so. Thanks for the help 🙂

I'm planning to write an article about web development with kotlin (Ktor in particular) - any suggestions or resources that could help me? 🙂 Thanks!

Talk to me 🙂 And read ktor.io

@rrader Rocker support is being developed in http://github.com/hexagonkt/hexagon however, I'm not developing it by myself. Last time I checked it was one of the top performers in benchmarks

I suggest moving this discussion to #server

📣 📣 Poll on Java 9 modules support: 1️⃣ needed badly 2️⃣ good to have 3️⃣ don’t care

Is it possible to run ktor on Java 9 without it?