perhaps you could change

dispatch

in

Thunk

to

operator invoke

Going through the tests for redux-kotlin and I’m not sure how useful this one is https://github.com/reduxkotlin/redux-kotlin/blob/2613d836aebf8195a88dbb3ed19f296358e0b572/lib/src/test/kotlin/org/reduxkotlin/ApplyMiddlewareTest.kt#L13

yes, I think that would work. I tried that for awhile and didn't find it too useful, but if your breaking it down by screen that may be beneficial to make sure all the actions are handled. These helper function would make it easy to declared a "sealedReducer" :

typealias SealedReducer<TState, TAction> = (state: TState, action: TAction) -> TState
typealias SealedReducer<TState, TAction> = (state: TState, action: TAction) -> TState

inline fun <TState, reified TAction> sealedReducer(crossinline reducer: SealedReducer<TState, TAction>): Reducer<TState> {
    return {state, action ->
        if (action is TAction) {
            reducer(state, action)
        } else {
            state
        }
    }
}
sealed class LoginScreenAction
class LoginButtonTap: LoginScreenAction()

val loginScreenReducer = sealedReducer<TestState, LoginScreenAction> { state, action ->
    when(action) {
        is LoginButtonTap -> state
    }
}

Cool, cool. Do you recommend just having 1 top level reducer? I can imagine it getting quite large. Would an AppStore and a FeatureStore make sense if you wanted to go multi-module and break things up?

The intended guarantee is that Redux eventually calls all subscribers with the most recent state available, but not that it always calls each subscriber for each action. The store state is available in the subscriber simply by calling store.getState()

This explanation is more about disallowing the action in the subscriber which i totally get and support. but having the most recent state in the subscriber could be easily solved with

(State) -> Unit

and you could eliminate a whole class of bugs

If that's a requirement, i would make thread confinement enforced by the library, just like Android enforces not accessing UI on the main thread. The critical block is probably with subscribe and dispatch. If you have multi-threaded subscribes, that changes the list of listeners, not necessarily all of them got in the list. Then if you dispatched, the

listeners.forEach

could have listeners mutated right in the middle of the loop which would be weird

How do i pass an extra argument when dispatching a thunk?

left some comments

PR up for the website! https://github.com/reduxkotlin/redux-kotlin/pull/21 Going to be more tweaks before publishing. Interested in feedback.

@Patrick Jackson Going forward, I’d recommend putting visual guidelines in the IDE for at least 100 chars. I generally like to break documentation at 80 which is the reason for the 2nd visual guide.

There should be a guide on testing in these docs. i imagine the testing strategy would be to unit test the reducers?

Essentially an interchangeble for kotlin-react-redux

Seems like compose would play pretty nicely with redux https://developer.android.com/jetpack/compose

Hi channel, I am wonder which is best practice, to have a unique store for the entire app or different stores for each activity(in case of android)?

is there any implementation of redux that is multiplatform? i hav the crazy idea to seralize the actions and send them between server and client is there such a thing yet ?

so.. i am planning to use redux to store the state of a boardgame (figure positions mostly) 1. what is the correct way for a reducer to fail ? eg. from a illegal action by the player 2. is it a smart idea to serialize the actions and have the client send to the server ? 3. assuming thats not a stupid idea.. can i hook up the store to autmatically send any changes via network (ktor and websocket)

otherwise.. what are the artifacts for the platforms ?

is there any smart solution for subscribers that want to process things added or removed from list / maps ? currently i keep a old copy and compare, i am pretty sure there gotta be a better approach

do i then still need to care about unsubscribing ? and what do i call for that ?

since the api is so close to reduxjs.. is there any code on kotlinJs to cast stuff to a kotlin-wrappers redux backed by reduxjs ?

How do i switch to store thread in common module with coroutines?

is there any contract stating that dispatch has to return the transformed state ? because to me the

redux.Store

api looks like it could return anything

when using kotlin-redux on js is there any point in adding a line like that ?

js("if(window.__REDUX_DEVTOOLS_EXTENSION__ )window.__REDUX_DEVTOOLS_EXTENSION__ ();else(function(f){return f;});")

https://github.com/lawik123/kotlin-poc-frontend-react-redux/blob/44eceb985a6871a2c13e6c5487777d55acf64bfb/src/main/kotlin/nl/lawik/poc/frontend/reactredux/Index.kt#L17

Getting the following on windows:

Could not find org.reduxkotlin:lib-win:0.3.1.
Searched in the following locations:
  - <https://jcenter.bintray.com/org/reduxkotlin/lib-win/0.3.1/lib-win-0.3.1.pom>
  - <https://repo.maven.apache.org/maven2/org/reduxkotlin/lib-win/0.3.1/lib-win-0.3.1.pom>
  - file:/C:/Users/mpetuska/.m2/repository/org/reduxkotlin/lib-win/0.3.1/lib-win-0.3.1.pom
  - <https://kotlin.bintray.com/kotlin-js-wrappers/org/reduxkotlin/lib-win/0.3.1/lib-win-0.3.1.pom>
  - <https://dl.bintray.com/kotlin/kotlinx.html/org/reduxkotlin/lib-win/0.3.1/lib-win-0.3.1.pom>

Am I missing something?

Anyone tried to use reduxkotlin on native? I keep getting

kotlin.native.concurrent.InvalidMutabilityException: mutation attempt of frozen kotlin.native.internal.Ref

when trying to createStore

i have no idea how i did not run into this before..

java.lang.IllegalStateException: You may not call the store from a thread other than the thread on which it was created.

but how would be the easiest way to lets say.. make sure that this does not happen by using the same thread / coroutine context ?

Hey folks how are others storing their state? For example, are you using a

data class

, a Map, or something else entirely? I'm coming from the JS/TS ecosystem where libraries like ReduxToolkit/Immutable.JS make this a straightforward decision but I'm curious what 'best practice' looks like here in kotlin-land 🙏 In my first attempt I'm using data classes but finding that only 1 or 2 layers of nesting starts to cause issues in my reducers. So i could either go with Maps and forget data classes or reduce the nesting... or perhaps theres a better way altogether?

Any ETA on when reduxkotlin will be published for windows? v0.4.0 still does not resolve windows artefact

Redux-Kotlin v0.4.0 is available! This updates to kotlin 1.3.70. Redux-kotlin-thunk is also updated to v0.4.0. Thunk has a breaking change where thunks are now a typealias, rather than an interface. Kotlin 1.3.70 fixed a bug that allows use of typealias and closer match to JS thunk api.