Channels
#rx
- r
rednifre
03/20/2017, 6:04 PMYes, that might be the case. - a
anstaendig
03/20/2017, 6:04 PMThere’s nothing wrong with saving something in variables, even with RxJava 😄 - r
rednifre
03/20/2017, 6:04 PMOn the other hand, I don't find the idea of an observable persistence that flows the credentials into the network adaptor that bad. - r
rednifre
03/20/2017, 6:04 PMThe credentials flow from the GUI into the persistence and from there into the interceptor. - z
zak.taccardi
03/20/2017, 6:05 PM@User uploaded a file:Screen Shot 2017-03-20 at 2.04.51 PM.png▾
- z
zak.taccardi
03/20/2017, 6:05 PMwhere
is a stream of your user as he's logged in or not over timeloggedInUser() - r
rednifre
03/20/2017, 6:05 PMOkay, but how do you handle the case where there is no user? - a
anstaendig
03/20/2017, 6:05 PMI think he’s talking about something else Zak - a
anstaendig
03/20/2017, 6:05 PMOr I’m totally off the track here 😄 - r
rednifre
03/20/2017, 6:06 PMWell, I might be talking about multiple things simultaneously, sorry 🙂 - r
rednifre
03/20/2017, 6:06 PMThat UserDb looks somewhat fine, I would use dependency injection to put that observable into the interceptor for the basic auth. - z
zak.taccardi
03/20/2017, 6:06 PM@rednifre that's the point of the sealed class. your
could be aUser
, or aUser.Authenticated
userNotLoggedIn - a
anstaendig
03/20/2017, 6:06 PMOne more thing regarding the observable that lets the credentials flow into network adapter - r
rednifre
03/20/2017, 6:07 PM@Zak, ah, so the user wouldn't be null but the interceptor would have to check if it's the NotLoggedIn user. Hm. - a
anstaendig
03/20/2017, 6:07 PMUsually Observables are used to observe some data and react to changes but all you want to do when that happens is to set them inside the network adapter - r
rednifre
03/20/2017, 6:07 PMThat's correct. - a
anstaendig
03/20/2017, 6:07 PMIt’s not that you want to do something else like chaining it - a
anstaendig
03/20/2017, 6:07 PMWhenever the credentials change, do some network call and what not - a
anstaendig
03/20/2017, 6:08 PMThat’s why I think the observable pattern is total overkill for that specific use case - r
rednifre
03/20/2017, 6:08 PMI'm not doing anything when they change, I only need the correct ones at the moment when I make the call. - r
rednifre
03/20/2017, 6:08 PMMakes sense. - z
zak.taccardi
03/20/2017, 6:08 PMI'd argue the observable pattern is never overkill because everything starts simple and increases its complexity over time - a
anstaendig
03/20/2017, 6:09 PMBut if you do not do any chaining whatsoever why would you use an observable just to set a value - r
rednifre
03/20/2017, 6:09 PMThere's still two cases: 1. when the credentials change they need to reach the network adapter 2. When the app does a cold start and the network adapter does the first call it needs to pull the credentials (if they are persisted). - z
zak.taccardi
03/20/2017, 6:09 PMbtw, this should totally be a thread - r
rednifre
03/20/2017, 6:10 PMI'm not sure if observables even work that way but I think of it as a pipe that can either take something pushed in on one end or have something pulled out the other end. - r
rednifre
03/20/2017, 6:11 PMSo when the credentials changed they get pushed through the observable to the network adapter and if the adapter starts and has no credentials in its local variable it pulls them through the observable out of the shared preference. - z
zak.taccardi
03/20/2017, 6:11 PMI wouldn't do that - z
zak.taccardi
03/20/2017, 6:11 PMyou can modify headers etc in retrofit calls themselves - a
anstaendig
03/20/2017, 6:11 PMThat’s what I’m saying the whole time Zak 😛