more than one?

that would be fine, why include that there? 🤔

of course,

<http://foo.com/?q=1&q=2&q=3>

because which one?

Just an idea. How about a function that returns a

List<String>?

which is null if any param is missing, or param values in order, so you can do this?

val (name, category, value) = mapQueryParams("n", "c", "v") ?: throw InvalidUrlParametersException()

because which one?

having multiple values for a query param is fine.. i'm not a big fan, but a lot of people do that

your idea is very neat though

@orangy this function will be pretty useless in java, is there any way to communicate that to users?

Ah, no idea. I’m Kotlin-only 🙂

lucky 😄

That’s my choice! 😄

@orangy thanks for your idea, it works beautifully

I think I’ll probably add it to #ktor as well 🙂

in that case, please review my implementation 😇

fun mapQueryParams(vararg keys: String): List<String>? = try {
    keys.map { servletRequest.getParameter(it) }.requireNoNulls().toList()
} catch (e: IllegalArgumentException) {
    null
}

looks fine

but shouldn’t

servletRequest

be a receiver for a function?

maybe it should, i don't know 🤔 i'm reading https://kotlinlang.org/docs/reference/lambdas.html#function-literals-with-receiver trying to see how it can be applied..

servletRequest

is a

javax.servlet.http.HttpServletRequest

, if that makes any difference

@orangy Does ktor differentiate

/?x=&y=

and

/?x&y

? (i.e. you can have

null

and empty string values)

I ask because http4k does that now but I'm not sure how useful that is in practice.

It doesn’t.

null

is there if you didn’t specify a parameter

I see. I chose to allow differentiating

/?x

from

/

(by allowing to get the list of parameters, even if they contain

null

value). Again, probably useful in very few cases.

Yep,

/?x

will get empty string for

x

, and

/

will get null for x

Hey there, does anyone have an example of a pretty complex API in ktor I can have a look at? I've seen tutorials telling you how to make a simple one, but I want to know how to structure an API with a fair amount of logic

May be ask in #ktor

In the wrong channel again...thanks 😛

(2 days late) yeah, seems most consistent for a query param value to always be a string (even empty) if the param key exists at all. bike-shedded this with myself the other day.

/?q=&q

would prob be

['', '']

though i could see an api like

req.query.listOf("q")

vs

req.query.get("q")

where the latter always returns the last value

@orangy For the record, I’d use Squash if you were going to continue work on it. I started building an app with it, then jumped ship when I heard it wasn’t being developed anymore.

Hey has anyone found a way to use Spek with Roboelectric ?

For anyone interested in testing http4k webapps, we've just released `http4k-testing-webdriver`; a lightweight, lightning fast (out-of-browser) Selenium webdriver implementation: https://www.http4k.org/guide/modules/webdriver/