kotlinlang #spek

@tom-j-b: currently no because you’re mutating the values. It’s not “resetting” anything after every execution of on. Is there a reason you want to have the mutable variable outside?

tom-j-b

02/18/2016, 11:14 AM

While typing an answer to your question I suddenly realised that, in the case I'm thinking of, I don't need multiple `on`s at all! Sorry about that. It turns out that I need only multiple `it`s. (And it seems there's no problem with multiple `it`s.)

tom-j-b

02/18/2016, 11:14 AM

It's funny how I didn't realise that until you asked that question. 😄

tom-j-b

02/18/2016, 11:15 AM

Though I guess there may be cases where multiple `on`s are useful, to avoid code duplication. Imagine testing StringBuilder, or something, and always starting with the same empty StringBuilder.

tom-j-b

02/18/2016, 11:20 AM

In that case, it'd be nice to say "Given an empty StringBuilder,

should produce

should produce `b`" rather than "Given an empty StringBuilder,

should produce

. Given an empty StringBuilder,

should produce `b`"

hhariri

02/18/2016, 11:36 AM

but you still say the same thing, however initialize the vars in the body of the on, no? Or am I missing something?

tom-j-b

02/18/2016, 11:45 AM

What I mean is that it'd be nice if we could say

val builder = StringBuilder()

only once (in the

given

function) and yet start each

on

function with an empty StringBuilder (even if the last

on

mutated their StringBuilder). This would avoid setup duplication.

tom-j-b

02/18/2016, 11:45 AM

It's possible that I'm misunderstanding something about Spek. 😄

robfletcher

02/18/2016, 7:06 PM

@jvtrigueros: d’oh I’m an idiot. I was misreading the table in the downloads page – it would make more sense (to me) if the latest release were at the top

jvtrigueros

02/19/2016, 5:21 AM

Yeah I agree simple smile, but at least I'm glad that there's a 1.0.0 compatible version.

hhariri

02/19/2016, 8:11 AM

TBH now that we’ve reached 1.0, I don’t think that table has any value anymore.

hhariri

02/19/2016, 8:11 AM

So we might as well remove it or reduce it to a single row: 1.0

hhariri

02/19/2016, 8:13 AM

Done.

dmarcato

02/20/2016, 12:05 AM

is Spek compatible with Robolectric? if not, is there any plan to support it?

hhariri

02/20/2016, 9:56 PM

@dmarcato: not familiar with Robolectric. Does it have any specific requirements ?

stanislav.erokhin

02/22/2016, 1:09 PM

@stanislav.erokhin has left the channel

dmarcato

02/23/2016, 7:42 AM

@hhariri: it requires your test to run with their

RobolectricTestRunner

that extends

BlockJUnit4ClassRunner

dmarcato

02/23/2016, 7:43 AM

do you know if there is any way to make them work together somehow?

hhariri

02/23/2016, 7:48 AM

@dmarcato: so you have to inherit from base class? If so, then unlikely 😞, cause we need a base class for Spek also….maybe time to re-examine yet another thing

dmarcato

02/23/2016, 7:49 AM

no need to inherit, just specify the runner with

@RunWith

hhariri

02/23/2016, 8:42 AM

then it should work….

dmarcato

02/24/2016, 5:20 PM

@hhariri: nope,

BlockJUnit4ClassRunner

can’t find runnable method inside a

Spek

class

dmarcato

02/24/2016, 5:21 PM

Copy code

java.lang.Exception: No runnable methods
	at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMethods(BlockJUnit4ClassRunner.java:191)
	at org.junit.runners.BlockJUnit4ClassRunner.collectInitializationErrors(BlockJUnit4ClassRunner.java:128)
	at org.junit.runners.ParentRunner.validate(ParentRunner.java:416)
	at org.junit.runners.ParentRunner.<init>(ParentRunner.java:84)
	at org.junit.runners.BlockJUnit4ClassRunner.<init>(BlockJUnit4ClassRunner.java:65)
	at org.robolectric.RobolectricTestRunner.<init>(RobolectricTestRunner.java:78)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
	at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:104)
	at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:86)
	at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
	at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
	at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
	at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:33)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)


Process finished with exit code 255

dmarcato

02/24/2016, 5:22 PM

my class looks like this:

Copy code

@RunWith(RobolectricTestRunner::class)
@Config(constants = BuildConfig::class, sdk = intArrayOf(21))
class PrefDelegateTest : Spek() { init {
    [...]
}}

dmarcato

02/24/2016, 5:23 PM

my understanding is that

BlockJUnit4ClassRunner

can only run methods, not classes

hhariri

02/24/2016, 6:07 PM

Then that's an issue yes :/

dmarcato

02/24/2016, 7:28 PM

any chance this will get supported?

hhariri

02/25/2016, 1:21 PM

@dmarcato: right now I can’t say, but if you log it I can take a look and see what it would imply….

dmarcato

02/25/2016, 8:51 PM

thanks, I created https://github.com/JetBrains/spek/issues/65 simple smile