kotlinlang #spek

not sure with the junit5 gradle plugin, you might have to just temporarily move the test cases. i’m just trying to think of ways you could narrow down the problem

05/17/2017, 6:30 PM

I guess one quick thing you could try is if you're sharing the kodein injector between tests, instantiate it specifically for that spek

jackmiras

05/17/2017, 6:30 PM

I've just tried explicitly mock the

request

and

response

objects and run the

UserPresenterTest

with the following command

gradle -Dtest.single=UserPresenterTest test

and I got a different error:

Copy code

Failures (1):                                                                                                                                        
  Spek:user.UserPresenterTest:given the user presenter:given a post action with a already registered user                                            
    => org.mockito.exceptions.misusing.UnfinishedVerificationException:                                                                              
Missing method call for verify(mock) here:                                                                                                           
-> at user.UserPresenter.render(UserPresenter.kt:105)                                                                                                
                                                                                                                                                     
Example of correct verification:                                                                                                                     
    verify(mock).doSomething()                                                                                                                       
                                                                                                                                                     
Also, this error might show up because you verify either of: final/private/equals()/hashCode() methods.                                              
Those methods *cannot* be stubbed/verified.
Mocking methods declared on non-public parent classes is not supported.

jackmiras

05/17/2017, 6:31 PM

The code now is looking like this:

Copy code

object UserPresenterTest : Spek({

    given("the user presenter") {

        val request = mock<Request>()
        val response = mock<Response>()
        
        given("a post action with a valid user to register") {

            afterGroup { userFactory.clear() }

            on("the attempt to register a valid user") {
                it("should have a positive match for valid user from json") {
                    val user = userFactory.build()
                    doReturn(user.toJson()).whenever(request).body()

                    <http://userPresenter.post|userPresenter.post>(request, response)
                    userPresenter.user.isValid().shouldBeTrue()
                }
            }
        }
    }

})

open class UserPresenter : UserContract {

    override fun post(request: Request, response: Response): Answer {
        user = request.bodyAsObject(User::class)
        if (userRepository.isAlreadyPersisted(user.email)) {
            return render(response, getMessage(request.locale(), "user_already_exists"), 409)
        } else if (user.isValid()) {
            user.logged = true
            userRepository.save(user)
            return render(response, user, 201)
        } else {
            return render(response, getMessage(request.locale(), "invalid_params"), 422)
        }
    }

    fun render(response: Response, message: String, status: Int): Answer {
        response.type("application/json")
        response.status(status) // This is the line number 105 referenced at the exception.
        return Answer(message, status)
    }

}

05/17/2017, 6:46 PM

Could it be because there's no when() for Response.status()?

jackmiras

05/17/2017, 6:56 PM

Let me try

robfletcher

05/18/2017, 11:21 PM

Is there any way to define a

subject

that has dependencies using

SubjectSpek

raniejade

05/21/2017, 12:22 PM

@rook sorry, just got back from vacation. Can you try removing

from

can't find previous dvir

artemiy

05/21/2017, 11:50 PM

Silly question, but where can I get the console runner? And does it play well with gradle configs? I'm using Vagrant so don't have any IDE integration unfortunately, but still want pretty logs

jackmiras

05/22/2017, 3:56 PM

@artemiy I don't know if this will solve you problem but when I whant to run the tests from terminal I just execute the

gradle junitPlatformTest

command

artemiy

05/22/2017, 3:59 PM

That's what I'm doing (well, normally

gradle test

but it runs the same thing), but it's just not looking very pretty

-.txt

artemiy

05/22/2017, 4:01 PM

The output of the console runner I've seen in some video was this nice tree like in the code itself and like what you get in the IDE plugin

rook

05/22/2017, 4:49 PM

@raniejade I removed the

, but it’s still acting up. I made a new separate project that is very basic to reproduce it. You can find the repo here: https://github.com/nukeforum/lunch-learn

rook

05/22/2017, 6:47 PM

@raniejade It looks like my problem is that

on{}

doesn’t return a group. It looks like it’s not meant to be used to nest groups of tests. Is this correct?

raniejade

05/23/2017, 12:54 AM

@rook you should treat

on

as a special kind of

test

, it represents a certain action. The

its

will normally contain your assertions.

✅ 1

jackmiras

05/23/2017, 3:17 PM

What do I do when I get this kind of error

=> java.lang.AssertionError: Expected class user.User to be an instance of class user.User

artemiy

05/23/2017, 3:24 PM

What's the code? The wording makes it seem like it got an instance of the class itself rather than an object of this class, but as I haven't seen this error before I'm not sure

jackmiras

05/23/2017, 3:31 PM

The code is this one:

Copy code

it("should KClass not be KClass<Any> instance") {
    repositoryMocked.findBy("_id", user.id, User::class)
    argumentCaptor<KClass<Any>>().apply {
        verify(repositoryMocked, atLeastOnce()).findBy(eq("_id"), eq(user.id), capture())
        thirdValue shouldBeInstanceOf User::class
    }
}

hhariri

05/23/2017, 8:41 PM

1.1.2 is now published and available on bintray/maven

👍 4

jasper

05/25/2017, 5:15 AM

Copy code

dependencies {
	compile("org.springframework.boot:spring-boot-starter")
	compile("org.hibernate:hibernate-validator")
	testCompile("org.springframework.boot:spring-boot-starter-test")
	testCompile 'org.jetbrains.spek:spek-api:1.1.2'
	testRuntime 'org.jetbrains.spek:spek-junit-platform-engine:1.1.2'

}

jasper

05/25/2017, 5:16 AM

@RunWith(JUnitPlatform::class)

<---- Unresolved 'JUnitPlatform::class'

jasper

05/25/2017, 5:16 AM

Where does it come from?

raniejade

05/25/2017, 5:17 AM

@jasper you need

org.junit.platform:junit-platform-runner