When i bump koltin to 1.1.3 na keep all-open plugin at 1.1.1 I do not get such warning, but this is more like a hack:)

Yeah I would not recommand that 😉

I will discuss with Juergen if open private method is a hard requirement then will ping @yan if needed

Thanks for raising this

If you manage to create a repro project that could help

I am not able to reproduce this warning in sample app, but it is easy to see difference in decompiled code in any project between Kotlin versions

just by opening/decompiling any .class with private methods

Ok so we only need protected and public method to be open

This message is printed because we don't restrict the check to public and private

https://github.com/spring-projects/spring-framework/blob/master/spring-aop/src/main/java/org/springframework/aop/framework/CglibAopProxy.java#L266 yep here it is

Could you please create an issue on asking for a public + protected check only on https://jira.spring.io/browse/SPR ?

I will fix it

yep will do

@dariuszbacinski Fixed https://github.com/spring-projects/spring-framework/commit/1e07468d20c49baeb441425c7d0df053cb5d3cd1

Thank you :)

hi guys, how do you do a

@Configuration

class in Kotlin?

I need to convert this to kotlin:

@Configuration
@ConfigurationProperties(prefix = "demo.security.jwt")
public class JwtSettings {
    /**
     * {@link JwtToken} will expire after this time.
     */
    private Integer tokenExpirationTime;

    /**
     * Token issuer.
     */
    private String tokenIssuer;
    
    /**
     * Key is used to sign {@link JwtToken}.
     */
    private String tokenSigningKey;

    ....

should I set the properties to null on initalization?

ConfigurationProperties

and

Configuration

are not the same thing, it should not be both

For

ConfigurationProperties

see :

https://github.com/mixitconf/mixit/blob/master/src/main/kotlin/mixit/MixitProperties.kt and https://github.com/spring-projects/spring-boot/issues/8762

For now use nullable

var

, we are working on proper support for Spring Boot 2.0 (not 100% sure yet but will try to make it)

I am following this repo, are you sure it's wrong? https://github.com/svlada/springboot-security-jwt/blob/7091258de487f1a5f7e82db7d67e6bcbb0a4c16a/src/main/java/com/svlada/security/config/JwtSettings.java

Why this should be a

@Configuration

?

If you remove this annotation does it fail ?

Yeah I think it shouldnt. The author probably made a mistake. Sorry. Since you are here, is JWT token authentication planned to be supported out of the box in Spring?

In Spring Security 5 I think yes, see https://spring.io/blog/2017/07/24/spring-security-5-0-0-m3-released

cool, thanks

It is not sure yet if this will be part of Spring Boot 2.0, so if people vote and show interest, that will help.