https://kotlinlang.org logo
Channels
Powered by
#spring
  • r

    rocketraman

    10/05/2017, 2:08 PM
    Re. the Async JDBC drivers and Postgres, see also https://github.com/impossibl/pgjdbc-ng/issues/78
  • o

    orangy

    10/05/2017, 8:10 PM
    I think this could be #server -wide discussion, not just spring.
  • v

    veiset

    10/06/2017, 8:24 AM
    How do you guys handle null-returns with Spring-data and CrudRepositories? Set the return type to 
    MyType?
    and handling it later or is there a more elegant way of doing it?
  • q

    qwert_ukg

    10/06/2017, 8:26 AM
    status codes
  • v

    veiset

    10/06/2017, 8:28 AM
    I mean when querying for data
  • s

    sdeleuze

    10/06/2017, 8:29 AM
  • s

    sdeleuze

    10/06/2017, 8:29 AM
    If you return nullable values in your custom interface, to be tested I am not sure. Spring Data Kay is expected to deal with nullable values
  • s

    sdeleuze

    10/06/2017, 8:30 AM
    So I guess it should be able to recognize nullable and non-nullable values
  • s

    sdeleuze

    10/06/2017, 8:30 AM
    If not, probably worse creating an issue
  • v

    veiset

    10/06/2017, 8:30 AM
    So the solution is to use Java Optionals? Then I think using optional kotlin types is just as well 🙂
  • s

    sdeleuze

    10/06/2017, 8:30 AM
    I have discussed that extensively with Spring Data team
  • q

    qwert_ukg

    10/06/2017, 8:30 AM
    if data not found it will be null or exception throwing ?
  • v

    veiset

    10/06/2017, 8:31 AM
    It will be null, I am just trying to figure out the idiomatic way of handling it
  • s

    sdeleuze

    10/06/2017, 8:31 AM
    They chose 
    Optional
    instead of nullable return value, there is pro and con for that but for Java 8+ and this use case that probably the right thing to do.
  • q

    qwert_ukg

    10/06/2017, 8:31 AM
    for 
    repo.findOne(id)
  • s

    sdeleuze

    10/06/2017, 8:31 AM
    For idiomatic way of handling null values, see
  • s

    sdeleuze

    10/06/2017, 8:32 AM
  • s

    sdeleuze

    10/06/2017, 8:32 AM
  • v

    veiset

    10/06/2017, 8:32 AM
    Thank you @sdeleuze! That was just what I was looking for
    👍 1
  • s

    sdeleuze

    10/06/2017, 8:33 AM
    The point I am not sure is if nullable/non-nullable values are correctly recongnized in custom interface return values, I will ask to Spring Data team.
  • s

    sdeleuze

    10/06/2017, 8:33 AM
    I mean to have return 
    null
    versus throwing an exeception behavior
  • q

    qwert_ukg

    10/06/2017, 8:35 AM
    it will return T!
  • v

    veiset

    10/06/2017, 8:36 AM
    Cheers. In my custom interface query it doesn't complain that it can return null, so I am allowed to write: 
    fun findOneByMarefAndMaid(maref: Int, maid: Int): MyType
    and it will not complain about it possibly being null, and will crash later when I try to destruct 
    MyType
    at a later time.
  • s

    sdeleuze

    10/06/2017, 8:37 AM
  • s

    sdeleuze

    10/06/2017, 8:48 AM
    So answer for Spring Data team, yes it should return 
    null
    when returning 
    T?
    and throw an exception when returning 
    T
    , see also this documentation PR just created about this topic https://github.com/spring-projects/spring-data-commons/pull/253/commits/1f126600767afae33eb470010bb1c6bf4929cfad
    💪 2
  • s

    sdeleuze

    10/06/2017, 8:49 AM
    If that does not work, please create an issue on Spring Data Commons bug tracker (and post the issue link here)
  • v

    veiset

    10/06/2017, 8:52 AM
    Sure thing. I'm just upgrading to M4, I'll report back.
  • s

    sdeleuze

    10/06/2017, 10:08 AM
    @veiset I think you need to M5 which is about to be released (or snapshots if you are in hurry and not afradi ^^)
  • v

    veiset

    10/06/2017, 10:37 AM
    Hehe, slightly afraid of running snapshots in this project unfortunately 😉 But thanks for the info and the commit to the docs, it looks like it will be resolved when I update at a later point. 👍 And if not I'll create an issue
  • s

    sdeleuze

    10/06/2017, 10:38 AM
    M5 is just around the corner, should be available shortly
1...122123124...173Latest