Thanks again for contributing

And @nfrankel or @gaetan (and others) feel free to contribute ideas or code on https://github.com/sdeleuze/spring-kotlin too 😉

With all-open plugin compiler that should avoid the need for

open

with CGLIB proxies

(not tested yet)

Kudos to Kotlin team for that 🙂

It would be nice to hear some feedback :)

@yan Hum, seems to not work yet https://github.com/sdeleuze/spring-boot-kotlin-demo/tree/all-open

Did I miss something?

Oh the old version on

kotlin-reflect

is in the classpath

Let me try with the latest one

Same error:

2016-12-17 00:33:49.242  WARN 35281 --- [           main] ationConfigEmbeddedWebApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.parsing.BeanDefinitionParsingException: Configuration problem: @Configuration class 'Application' may not be final. Remove the final modifier to continue.

@sdeleuze Currently supported list of Spring annotations: https://github.com/JetBrains/kotlin/blob/master/plugins/allopen/allopen-ide/src/AllOpenMavenProjectImportHandler.kt#L26. Looks like

@SpringBootApplication

is not annotated with any of them, so the class won’t become open. What else annotations should be supported then?

This annotation is meta annotated with @Component

SpringBootApplication > SpringBootConfiguration > Configuration > Component

(On my smartphone so I write that without the source but that's to show the principle)

There is a wide range of annotations but almost all are meta annotated by @Component

So if you check that recursively kotlin-spring should work out of the box for most use cases.

Ah, ok. I investigate this soon

I tested the plugin and it works awesome being the compiler plugin that is detected via ServiceLoader api as opposed to using some asm/cglib hacks. What it means is that plugin also works when you run the spring application from a main method or run integration test from IntelliJ. As long as the plugin is on the class path it will be detected by ServiceLoader and you are done.

@pawelb Are you about all-open compiler plugin jar? If yes, why do you put it in the runtime dependencies?

@yan If I remove the kotlin-maven-allopen from runtime dependency than running application from main class or running a test from IDE will not remove final modifier. So the solution is to add plugin with scope provided.

@pawelb Thank you, I’ll investigate this. By the way, it would be much more easier to fix the problem if we had something like a reproducible scenario or a sample project

Will create soon

@yan there was something going wrong with my IntelliJ as I switched to a different machine and just adding plugin as described in the https://discuss.kotlinlang.org/t/kotlin-1-0-6-eap/2117 worked for me. This is example project I tested against https://github.com/pbartoszek/kotlin-allopen. So it looks like Intellij needs to detect somehow that compiler plugin is defined in pom and run it behind the scene...

@sdeleuze just read your messages

@Bean

is not annotated with

@Component

so methods annotated with

@Bean

won’t be

open

by default is that right?

I think classes detected by all open plugin will get the class and al their methods

open

by default

If not

@Bean

should be added to the list indeed

But if that works like I described it is not needed

Does anyone have any recommendations as to a package for using MongoDB, Kotlin, and Spring-boot?