Channels
#spring
- n
nfrankel
05/31/2017, 7:57 AM@jdvr yes, it works - n
nfrankel
05/31/2017, 7:58 AM - j
jasper
05/31/2017, 9:46 AMIs the feature that alleviates the need to mark
and@Transactional
classes as explicitly@Configuration
(they become implicitly so by virtue of the annotation) ready and available in Spring Boot 1.5.3?open - j
jasper
05/31/2017, 9:59 AMAFAIK the jar file would declare in meta data when an annotation implies open - h
herder
05/31/2017, 10:00 AMIf you initialize your project via start.spring.io it should work OOTB via the
plugin for Gradle/Mavenkotlin-spring - h
herder
05/31/2017, 10:00 AM - j
jasper
05/31/2017, 10:01 AMsounds good. Do you know how to turn it on for an existing Spring Boot proj? - h
herder
05/31/2017, 10:02 AMYep, just add it to your pom.xml/build.gradle - j
jasper
05/31/2017, 10:02 AMJust add Kotlin compiler plugin? - h
herder
05/31/2017, 10:02 AMYes, the
plugin abovekotlin-spring - j
jasper
05/31/2017, 10:03 AMexcellent 🙂 Does it work when choosing 'Rebuild' in IntelliJ too? - h
herder
05/31/2017, 10:03 AMYes, IntelliJ has stellar support for Kotlin (as it should 🙂 ), so it should work by just reimporting the project - j
jasper
05/31/2017, 10:04 AMMaking a sample app for Spring Boot, Spring Data Neo4j, Spring Security. . maybe I could ask @sdeleuze talk about having a start.spring.io template for that too. - j
jasper
05/31/2017, 10:04 AMperfect 🙂 trying it now - h
herder
05/31/2017, 10:05 AM👍 have fun!🙂 1 - j
jasper
06/01/2017, 11:26 AMall-open worked very nicely. I found one case where it didn't: - j
jasper
06/01/2017, 11:26 AMCopy codeclass UserControllerTests : ControllerTest() { @Test fun getMyProfile() { val accessToken: String = login("<mailto:jasper@appsquick.ly|jasper@appsquick.ly>", "password").accessToken RestAssured.given().header("Access-Token", accessToken). header("API-Key", "e8f3fdcc-8825-11e5-af63-feff819cdc9f"). get("/user/mine"). peek().then(). body("email", IsNull.notNullValue()) } } - j
jasper
06/01/2017, 11:27 AMCopy code@RunWith(SpringRunner::class) @SpringBootTest(classes = arrayOf(ApplicationAssembly::class), webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) abstract class ControllerTest - j
jasper
06/01/2017, 11:27 AMgives: - j
jasper
06/01/2017, 11:27 AMorg.springframework.aop.framework.AopConfigException: Could not generate CGLIB subclass of class [class movies.spring.data.neo4j.api.endpoints.secured.UserControllerTests]: Common causes of this problem include using a final class or a non-visible class; nested exception is java.lang.IllegalArgumentException: Cannot subclass final class movies.spring.data.neo4j.api.endpoints.secured.UserControllerTests - j
jasper
06/01/2017, 11:28 AM^--- Now why does it want to proxy the test class? Is it because all Spring integration tests are implicitly transactional? - j
jasper
06/01/2017, 11:29 AMWhich is nicer? Marking the test
or@Transactional
?open - r
roberto.guerra
06/01/2017, 2:45 PMit doesn’t have a spring annotation. The
plugin inspects the classes with a spring annotation, and opens them before compiling.all-open - r
roberto.guerra
06/01/2017, 2:45 PMfor tests, I prefer to be explicit and add
.open - d
dariuszbacinski
06/01/2017, 7:43 PMit might be better to create your own annotation that will contain both @RunWith and @SpringBootTest and then configure all-open plugin to open classes with this annotation - d
dariuszbacinski
06/01/2017, 7:44 PMusing inheritance in tests is a bad smell - d
dariuszbacinski
06/01/2017, 7:47 PM - d
dariuszbacinski
06/01/2017, 7:50 PMhttps://kotlinlang.org/docs/reference/compiler-plugins.html according to this your meta annotation should work out of the box without additional configuration of all-open plugin - d
dariuszbacinski
06/01/2017, 7:51 PMofc if you are using kotlin-spring plugin which configures all-open plugin with spring annotations - j
jasper
06/02/2017, 4:36 AM
<--- It would be nice to declare Kotlin-esque default values. Has this one been logged?fun graph(@RequestParam(value = "limit", required = false) limit: Int = 100): Map<String, Any>