Hi guys, I need to report parsing errors on the body of a retrofit request to our crash reporting tools (as handled exceptions). The problem is that I would need the url we are hitting too, and I do not see how I can get the real one with its parameters, The best I can get is:

to.hopin.android.core.exceptions.DecodeNetworkException: Couldn't decode response from /api/v2/events/{eventId}/locale
        at to.hopin.android.core.moshi.ErrorAwareMoshiResponseBodyConverter.convert(ErrorAwareMoshiConverterFactory.kt:69)
        at to.hopin.android.core.moshi.ErrorAwareMoshiResponseBodyConverter.convert(ErrorAwareMoshiConverterFactory.kt:60)
        at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:243)
        at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:153)
        at com.google.firebase.perf.network.InstrumentOkHttpEnqueueCallback.onResponse(InstrumentOkHttpEnqueueCallback.java:69)
        at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:919)
     Caused by: com.squareup.moshi.JsonDataException: com.squareup.moshi.JsonDataException: Expected a name but was NULL at path $.custom_text at $.custom_text
        at com.squareup.moshi.AdapterMethodsFactory$1.fromJson(AdapterMethodsFactory.java:101)
        at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:46)
        at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:27)
        at to.hopin.android.core.moshi.ErrorAwareMoshiResponseBodyConverter.convert(ErrorAwareMoshiConverterFactory.kt:66)
        at to.hopin.android.core.moshi.ErrorAwareMoshiResponseBodyConverter.convert(ErrorAwareMoshiConverterFactory.kt:60) 
        at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:243) 
        at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:153) 
        at com.google.firebase.perf.network.InstrumentOkHttpEnqueueCallback.onResponse(InstrumentOkHttpEnqueueCallback.java:69) 
        at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519) 
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 
        at java.lang.Thread.run(Thread.java:919) 
     Caused by: com.squareup.moshi.JsonDataException: Expected a name but was NULL at path $.custom_text

Any ideas?

If you have the Retrofit Call object, you can get it's OkHttp request which has the URL. https://square.github.io/retrofit/2.x/retrofit/retrofit2/Call.html#request--

Just catch and rethrow with that extra information

thanks for the hint, to be fair I was trying to avoid using the Call object as that would force us to change many things

No. We recommend Spoon: https://spoon.gforge.inria.fr/

Oh for Kotlin yeah you're out of luck unless you builds on PSI

Can I use

Timeouts

with okio on native ? Looks like it's mostly a JVM thing ?

Are there any plans to add more stuff there using

select

or something else? Or is there a fundamental reason this wouldn't work ?

No concrete plans yet. Obviously it's an important concept to have long term though

TCP and TLS happen inside the JDK

Neat, needed something like this. Thanks 😊😊😊

Does anyone know why this custom

Moshi

adapter (for serialization only) is not being called? If i replace

ApiType

with the specfic enum type (

Gender

) it works.

class ApiTypeAdapter {
  
  @ToJson
  fun toJson(apiType: ApiType): Int {
    return apiType.id
  }
}

interface ApiType {
  val id: Int
}

enum class Gender: ApiType {
  MALE {
    override val id: Int = 1
  },
  FEMALE {
    override val id: Int = 2
  }
}

I don’t think it works that way. Imagine if your enum implements multiple interfaces. How would moshi know how to serialize it? (PS. not sure about this! Square guys can easily tell you tho)

you’ll have to create a polymorphic adapter

there’s some example code in the class doc here: https://github.com/square/moshi/blob/master/adapters/src/main/java/com/squareup/moshi/adapters/PolymorphicJsonAdapterFactory.java

How do I make a

com.squareup.moshi.JsonReader

read from a String?

JsonReader.of(Buffer().writeUtf8(string))

In general, if possible, feed Moshi bytes, not strings

I meanwhile switched to

JsonReader.of(Buffer().write(byteArray))

. Is this right?

(I'm trying to parse the response to

<http://java.net|java.net>.http.HttpClient.sendAsync()

without blocking the thread.)

Is it possible to mark

SQLDelight's

generated classes/interfaces as

internal

? I would like to use it in the library (multiplatform, targeting iOS and Android) and I don’t want to pollute the public interface with these generated types I saw this issue: https://github.com/cashapp/sqldelight/issues/1333 but unfortunately hiding database in different gradle module is not an option, because of lack of native possibility to build library from multiple modules (fataar)

[OkHttp]

What are exactly

readTimeout

,

connectTimeout

and

writeTimeout

? If we are using default values for them (which are 10s) with a single retry, is it correct to say that the user might have to wait at most

2 * (10 + 10 +10)=60s

for the actual response? We are investigating some timeout inconsistency between

android

and

iOS

platforms regarding api timeouts.

they are not whole-request or whole-response timeouts, no. they are for individual read and write calls to the underlying socket for which there are usually many per request and response

i believe the whole-request timeout is called callTimeout

Ok, just to clarify: when making a request there might be several writes into the socket for writing the request and several reads for reading the response plus the time to stabilish a connection? Is there a particular strategy OkHttp uses for each individual operation. e.g. a buffered reader or something? Despite what you said about

callTimeout

, which is a change we want to make. I’m trying to check if its possible to calculate an upper limit for our current requests latency.

strictly speaking the upper limit is huge:

connectTimeout + (writeTimeout * request byte count) + (readTimeout * response byte count)

instead you want the call timeout

I think I finally found out why the sqldelight database is missing from time to time thanks to the help of gradle 7 🙂 https://github.com/cashapp/sqldelight/issues/2119#issuecomment-806397886

[okio] Hi I would like to remove 4 Bytes from the end of a buffer. Is there something like a cursor to move to a specific position and skip the bytes from this point or can the buffer reversed and then skip 4 bytes?