hfhbd
09/26/2022, 3:36 PMLandry Norris
09/28/2022, 1:30 PMif(!fileSystem.exists(path)) fileSystem.createDirectory(path, true)
. I also have a log on the line before printing the value of the exists check. In my logs, I see
Does it exist yet? false
Uncaught Kotlin exception: okio.IOException: File exists
I know that this function will only run on the main thread, so it’s not a threading issue, and I’m using FileSystem.SYSTEM on iOS. If I set mustCreate to false, then it runs the createDirectory line, but no folder is created. Logs also show that the parent path exists and is definitely in my app’s folder.grahamborland
09/29/2022, 3:00 PM@Composable
functions in my commonMain
, iosMain
and jsMain
sourceSets, but not in androidMain
(Unresolved reference: Composable). Do I need to add an explicit Compose dependency to androidMain
but not the others?eygraber
09/29/2022, 8:16 PM(iv) They may not download or install standalone apps, kexts, additional code, or resources to add functionality or significantly change the app from what we see during the review process.I think there were a few mentions of this in https://www.droidcon.com/2022/09/29/dynamic-code-with-zipline/; is it as simple as interpreting the js that makes Apple OK with it, or is there still a risk of getting removed from the App Store over using Zipline?
jw
09/29/2022, 8:31 PMjw
09/29/2022, 8:33 PMjw
09/29/2022, 8:34 PMgoogle()
repo available? The Android variant uses the Google runtime which comes from Google Maven. if it failed to resolve it may not work in Android-specific source setseygraber
09/30/2022, 2:48 AMjw
09/30/2022, 2:48 AMjw
09/30/2022, 2:50 AMeygraber
09/30/2022, 2:50 AMeygraber
09/30/2022, 2:59 AMjw
09/30/2022, 3:11 AMeygraber
09/30/2022, 3:29 AMjw
09/30/2022, 3:31 AMDjaka Pradana Jaya Priambudi
10/03/2022, 10:41 AMsearch
I see in all of your presentation that you guys declared inside the composable like this:
@Composable
fun present(event: Flow<Foo>) {
var search by remember { mutableStateOf(") }
...
}
Why do this? Won't this make it hard to split the code into smaller chank?
Suppose we have lot of events that modify search
like
CollectEffect(event) {
when (it) {
Event A -> search = it.query
Event B -> {
saveToRecentSearch()
search = ""
}
Event C -> ...
}
}
We can't extract event B into a completly different function because search
is inside the present
function
I'm a bit confused about this, thank youBenoit Quenaudon
10/03/2022, 10:42 AMDjaka Pradana Jaya Priambudi
10/03/2022, 10:43 AMsearch
? except if i put lamda parameter
fun bar(search: String) {
saveToRecentSearch(search)
search = "" // Can't do
}
fun bar(search: String, changeSerch: (String) -> Unit { // Possible but a bit painful as I need to write `search = it` in the collect efect
saveToRecentSearch(search)
changeSearch("")
}
Benoit Quenaudon
10/03/2022, 10:49 AMfun something(searchSetter: (String) -> Unit)
and call that.
I don’t really know how to set a mutableState field manually but if that’s easy, you woudn’t use the delegate on search and would be able to pass MutableState<String>
to the method.Benoit Quenaudon
10/03/2022, 10:50 AMDjaka Pradana Jaya Priambudi
10/03/2022, 10:52 AMclass Presenter: MoleculePresenter {
var search by mutableStateOf(")
@Composable
fun present(event: Event): State {
CollectEffect(event) {
when(event) {
eventB()
}
}
...
}
private fun eventB() {
saveToRecentSearch(search)
search = ""
}
}
But after seeing lot of presentation from cashapp or regarding molecule, none of them are doing this so I'm curious why they didn't do thisBenoit Quenaudon
10/03/2022, 10:52 AMsearch = ""
without delegates.Djaka Pradana Jaya Priambudi
10/03/2022, 10:53 AMBenoit Quenaudon
10/03/2022, 10:54 AMBenoit Quenaudon
10/03/2022, 10:54 AMDjaka Pradana Jaya Priambudi
10/03/2022, 10:55 AMBenoit Quenaudon
10/03/2022, 10:57 AMDjaka Pradana Jaya Priambudi
10/03/2022, 10:58 AMBenoit Quenaudon
10/03/2022, 11:01 AMjessewilson
10/03/2022, 11:08 AMwhen
clauses on events, and that outweighs the benefits of decomposing things into different places