What is the most performant way to check if two files have equal contents with

okio

? The trivial thing to do is something like

bufferedSource.readUtf8() == otherSource.readUtf8()

but I suspect it's not that good to do this.

it's going to be a lot of code

you'll want to grab the unsafe cursor from each buffer which backs the buffered source and then use something like https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Arrays.html#mismatch(byte%5B%5D,int,int,byte%5B%5D,int,int) on the backing byte arrays

the quickest way to do it is probably to call

request(Segment.SIZE)

on each

BufferedSource

to get a whole segment's byte array to be filled and then do a mismatch on that

then you only really have to handle the last case where the segment will only be partially filled

also make sure you're starting with a simple

size != other.size

check

a reasonably fast way would be to do the

request(Segment.SIZE)

thing and then call

readByteString()

which will create a

ByteString

that shares the backing

Segment

. Then you can do a simple

==

.

you'll probably hit like 99% performance of the unsafe cursor way with about 10% of the code

Great! Thank you! I can handle it getting verbose, because this would be one function in the end which will be reused.

Consider checking the SHA256 of the files instead? Though you have to read the whole file even if they’re different on the first byte

Using kotlin Poet, is it possible to write:

whaever?.let {
 // whatever
}, // <- the comma!

Basically, just a comma after invoking

endControlFlow()

?

I would suggest not using control flow for that and instead doing a multiline codeblock.

Actually:

fun CodeBlock.Builder.endControlFlow(format: String, vararg args: Any) = apply {
    unindent()
    add("}$format\n", args)
}

works 🙂 I thought the iner functions of

endControlFlow

where private, but turns out it is just an

add("}\n")

I am wanting to setup a meta adapter that will let me break down then try different qualifiers for a given property. Wondering if I am hitting the limits of the language here. It would seem you can't do any arbitrary annotation as an input? (Ideally you could tell it only other JsonQualifier annotated annotations, but that is sort of secondary here)

@JsonQualifier
annotation class WithFallback(
    vararg val qualifiers: Annotation
)

context: github has json that is inconsistent between different types of webhook payloads. accident of history i suspect.

"created_at": 1459436810
"created_at": "2023-01-12T22:40:19Z"

Ideally it would looks something like this in usage.

@WithFallback(qualifiers = [ISOZonedDateTime(), EpochMillis()]) val created_at: ZonedDateTime,

Not really about a square library, but wondering if any of the giant square projects have gradle filesystem watching enabled. I have a large project (not close to square size though) that has it enabled, and by disabling it I got a massive speed up in my ephemeral CI builds (still haven't tested locally).

we do!

I also vaguely remember reading a blog post that it's now enabled by default for all gradle projects…

Yup it is enabled by default. Although for an ephemeral build I guess it wouldn't really do anything other than be overhead...

I would really appreciate it if you cut a Kotlin 1.8 release. We thought that we were blocked by compose but actually sqldelight is also blocking.

Everyone is aware of the need

OkHttp's HttpUrl(.Builder) - it seems there is no sane way to insert/prepend path segment (we are adding lang to the url). Isn't that an API that could be added? thx

please file feature requests as issues on the GitHub project

seems like there should be an index-accepting variant of add

although you could do it today by clearing all the segments on the builder, adding your new one, and then adding all of the ones from the original

Is it possible that

BufferedSink.writeAll( BufferedSource)

swallows some exceptions leading to nothing written?

no. it's not that complicated of a function. https://github.com/square/okio/blob/5da7250e4edeaec8bed55cf3c2603685610b0ed2/okio/src/commonMain/kotlin/okio/internal/-RealBufferedSink.kt#L90-L99

are you calling it from Swift?