kotlinlang #squarelibraries

I don’t know why for progress you use Channel, so in my implementation I just use lambda for that Also this implementation supports cancallation and do not block coroutine that invokes this function, only threads of a separate dispatcher

gildor

05/28/2018, 6:13 AM

Not 100% sure that my usage of okio is completely correct and efficient, but should work

dave08

05/28/2018, 6:14 AM

The channel was to conflate android notifications, which can't take too many updates at a time, but I could always do that in the calling object

gildor

05/28/2018, 6:15 AM

You can wrap progress to channel, if you need this, but do not use send, otherwise you will suspend downloading and it not what you probably want, use

offer

instead

gildor

05/28/2018, 6:18 AM

I have a small comment in

main

function, just wrap downloading to

async

coroutine builder

dave08

05/28/2018, 6:22 AM

Thanks, I guess I could add a range param for that, that code is a very good start! 😉

Paul Woitaschek

06/01/2018, 10:02 AM

At my company we have quite the problem because of okhttp not revalidating the requests (added a testcase): https://github.com/square/okhttp/issues/4043

Paul Woitaschek

06/01/2018, 10:02 AM

Could you take a quick look and tell me if I have a fundamental misunderstanding here?

sierisimo

06/05/2018, 5:40 PM

Hi, not new in the slack but new posting instead of reading. I’m working on a personal project and having a small problem with Moshi. Someone familiar with:

java.lang.IllegalArgumentException: No JsonAdapter for ? (with no annotations)

? I saw a few issues on github but the use wildcards. I’m not. I’m also using Koin for connecting the parts but seems like a problem from moshi as the exception starts there.

eric

06/05/2018, 5:47 PM

without seeing the model, it's hard to guess what invalid type is trying to be used. if you put a breakpoint before that exception is thrown in the Moshi class, you can inspect the

type

. i'd be curious to hear what it is if it's not a wildcard.

sierisimo

06/05/2018, 8:19 PM

Sure, I can share everything:

sierisimo

06/05/2018, 8:24 PM

@sierisimo uploaded a file: MoshiError

MoshiError.kt

sierisimo

06/05/2018, 8:25 PM

@sierisimo uploaded a file: SchoolMoshiAdapter.kt

SchoolMoshiAdapter_kt.kt

sierisimo

06/05/2018, 8:25 PM

Still stuck on what’s wrong 😕

eric

06/05/2018, 8:29 PM

List<Building>, List<BuildingRoom>, etc. probably get converted into

List<? extends Building>

List<@JvmSuppressWildcards Building>

would fix that.

eric

06/05/2018, 8:30 PM

Map<String, Any>

Map<String, @JvmSuppressWildcards Any>

is my guess, but i haven't looked at it yet.

sierisimo

06/05/2018, 8:31 PM

Ok I’ll give a try

sierisimo

06/05/2018, 9:01 PM

WOW! It worked. Not as smooth as I expected but it worked.

sierisimo

06/05/2018, 9:01 PM

I have to replace my data class from my common module with a custom one with annotations in JVM module… but well… it works now.

sierisimo

06/05/2018, 9:01 PM

Amazing @eric. Thanks a lot.

eric

06/05/2018, 9:04 PM

agree that this is weird. we should at least document it if not do something in the reflective artifact to make it better. file an issue on GitHub if you get a minute, or i'll file one later tonight. if you're into annotation processing, the kotlin-codegen will remove this awkwardness.

K 1

eric

06/05/2018, 9:04 PM

thanks for flagging it as a pain point.

sierisimo

06/05/2018, 10:19 PM

Thanks a lot. I’ll open the issue tonight on gh

eric

06/06/2018, 2:03 AM

https://github.com/square/moshi/issues/573

🐿️ 1

ashishkrishnan

06/08/2018, 10:47 AM

What would be the alternative to TypeName.get() of JavaPoet in KotlinPoet?

Copy code

val name: String = // ... //
PropertySpec
        .builder(name,  ??? )

type would be a classtype which is also generated & TypeName.get() is marked as

internal

eric

06/08/2018, 7:01 PM

TypeNames.get(TypeMirror)

(for Java users) and there's a

asTypeName()

extension on TypeMirror.

👍 1

eric

06/08/2018, 7:01 PM

for Kotlin users

myanmarking

06/14/2018, 9:42 AM

Copy code

class NullPrimitiveTypeAdapter {
    @FromJson
    fun intFromJson(@NullableInt @Nullable value: Int?): Int = value ?: 0

    @ToJson
    @NullableInt
    fun toFromJson(value: Int): Int? = throw UnsupportedOperationException()

    @FromJson
    fun floatFromJson(@NullableFloat @Nullable value: Float?): Float = value ?: 0f

    @ToJson
    @NullableFloat fun floattoJson(value: Float): Float? = throw UnsupportedOperationException()
}

@MustBeDocumented
@Retention(AnnotationRetention.RUNTIME)
annotation class Nullable

@Retention(AnnotationRetention.RUNTIME)
@JsonQualifier
annotation class NullableInt

@Retention(AnnotationRetention.RUNTIME)
@JsonQualifier
annotation class NullableFloat

myanmarking

06/14/2018, 9:42 AM

Copy code

open class MeasureBodyDto(
    val manualMode: Boolean,
    @NullableFloat val skeletalMuscleRate: Float = 0f