https://kotlinlang.org logo
Channels
Powered by
#squarelibraries
  • m

    myanmarking

    06/14/2018, 9:42 AM
    Copy code
    No JsonAdapter for class java.lang.Float annotated [@com.x.core.network.retrofit.moshi_converters.nullable.NullableFloat()]
  • m

    myanmarking

    06/14/2018, 9:42 AM
    why does moshi complains i dont have an adapter?
  • m

    myanmarking

    06/14/2018, 9:43 AM
    maybe it is related to default arguments, that use a second constructor and annotations are not present there ?
  • m

    myanmarking

    06/14/2018, 9:43 AM
    also added the adapter:
    Copy code
    .add(NullPrimitiveTypeAdapter())
            .add(KotlinJsonAdapterFactory())
  • m

    myanmarking

    06/14/2018, 9:45 AM
    any help would be appreciated
  • e

    eric

    06/14/2018, 2:21 PM
    I don't see an adapter for making a NullableInt or NullableFloat. The fromJson needs to have a parameter type that has a known adapter, and the toJson needs to have a return type that has a known adapter. Looks like the adapters above have the opposite.
    👏 2
  • l

    ludwig

    06/18/2018, 8:19 PM
    I have a problem dealing with Moshi, sealed classes, and custom type adapters. I specified my question in a gist, instead of filling the chat: https://gist.github.com/LudwigSlotte/7471d5d5bdedd582a70920823d0ce496 - In short: I would be able to get specific type’s from Json, using the custom adapter, but having problem with nesting.
  • e

    eric

    06/19/2018, 12:40 AM
    it's slightly unfortunate that you can't do:
    Copy code
    @FromJson
private fun fromJson(
  response: Response,
  circleAdapter: JsonAdapter<Layer.Circle>,
  rectangleAdapter: JsonAdapter<Layer.Rectangle>,
  squareAdapter: JsonAdapter<Layer.Square>
): Layer {
  return when (response) {
    TypeEnum.circle -> circleAdapter.fromJsonValue(response.layer)!!
    TypeEnum.rectangle -> rectangleAdapter.fromJsonValue(response.layer)!!
    TypeEnum.square -> squareAdapter.fromJsonValue(response.layer)!!
  }
}
    and instead have to do:
    Copy code
    @FromJson
private fun fromJson(
  reader: JsonReader,
  responseAdapter: JsonAdapter<Response>,
  circleAdapter: JsonAdapter<Layer.Circle>,
  rectangleAdapter: JsonAdapter<Layer.Rectangle>,
  squareAdapter: JsonAdapter<Layer.Square>
): Layer {
  val response = responseAdapter.fromJson(reader)!!
  return when (response.type) {
    TypeEnum.circle -> circleAdapter.fromJsonValue(response.layer)!!
    TypeEnum.rectangle -> rectangleAdapter.fromJsonValue(response.layer)!!
    TypeEnum.square -> squareAdapter.fromJsonValue(response.layer)!!
  }
}
    but polymorphic stuff is rare enough. responded with a working test case on your gist.
  • l

    ludwig

    06/19/2018, 8:59 AM
    @eric Thank you very much Eric!
  • m

    myanmarking

    06/20/2018, 12:37 PM
    @eric what do you mean?
  • m

    mbonnin

    06/20/2018, 3:02 PM
    Using moshi codegen, is there a way to get an generated 
    JsonAdapter.Factory
    supporting all the generated 
    JsonAdapters
    ?
  • m

    mbonnin

    06/20/2018, 3:03 PM
    This is mentioned at the end of https://medium.com/@sweers/exploring-moshis-kotlin-code-gen-dec09d72de5e but from what I understand this is left as an exercise to the reader ?
  • e

    eric

    06/20/2018, 5:24 PM
    You really don't need to. The generated adapters will be used automatically. Yes, there's no built-in way to generate such a factory.
  • m

    mbonnin

    06/20/2018, 8:48 PM
    Indeed, thanks !
  • m

    myanmarking

    06/21/2018, 10:06 AM
    can any1 help me debug this stacktrace
  • m

    myanmarking

    06/21/2018, 10:06 AM
    Copy code
    at com.squareup.moshi.JsonUtf8Reader.nextDouble(Unknown Source)
        at com.squareup.moshi.StandardJsonAdapters$6.toJson(Unknown Source)
                                                     fromJson
        at com.squareup.moshi.ClassJsonAdapter.fromJson(Unknown Source)
                                               toJson
        at com.squareup.moshi.JsonAdapter$2.fromJson(Unknown Source)
                                            toJson
        at com.squareup.moshi.CollectionJsonAdapter.newLinkedHashSetAdapter(Unknown Source)
                                                    fromJson
        at com.squareup.moshi.CollectionJsonAdapter$2.newCollection(Unknown Source)
                                                      toJson
                                                      fromJson
        at com.squareup.moshi.JsonAdapter$2.fromJson(Unknown Source)
                                            toJson
        at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(Unknown Source)
                                                                convert
        at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(Unknown Source)
                                                                convert
        at retrofit2.ServiceMethod.toResponse(Unknown Source)
        at retrofit2.OkHttpCall.parseResponse(Unknown Source)
        at retrofit2.OkHttpCall.execute(Unknown Source)
        at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(Unknown Source)
        at io.reactivex.Observable.subscribe(Unknown Source)
                                   subscribe
                                   subscribe
                                   subscribe
                                   subscribe
                                   subscribe
        at retrofit2.adapter.rxjava2.BodyObservable.subscribeActual(Unknown Source)
        at io.reactivex.Observable.subscribe(Unknown Source)
                                   subscribe
                                   subscribe
                                   subscribe
                                   subscribe
                                   subscribe
        at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(Unknown Source)
        at io.reactivex.Scheduler$DisposeTask.run(Unknown Source)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(Unknown Source)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(Unknown Source)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:272)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:762)
  • m

    myanmarking

    06/21/2018, 10:07 AM
    the code work in debug build, but fails with this in release. i can’t trace the source
  • j

    julioyg

    06/21/2018, 11:15 AM
    it sounds like proguard configuration
  • m

    myanmarking

    06/21/2018, 11:28 AM
    i had some properties annotated with a JsonQualifier, in kotlin
  • m

    myanmarking

    06/21/2018, 11:28 AM
    this is necessary in release, no idea why:
    Copy code
    @get:NotNullableFloat @NotNullableFloat
  • m

    myanmarking

    06/21/2018, 11:28 AM
    the “get” part, without it, it only runs in debug
  • h

    hmole

    06/22/2018, 7:38 PM
    @jw Does https://github.com/square/AssistedInject works with Kotlin?
  • j

    jw

    06/22/2018, 7:38 PM
    yes
  • j

    jw

    06/22/2018, 7:38 PM
    we used it exclusively from Kotlin
  • h

    hmole

    06/22/2018, 7:40 PM
    Any code examples that showcases a simple assisted factory?
  • j

    jw

    06/22/2018, 7:44 PM
  • h

    hmole

    06/22/2018, 7:46 PM
    Thanks
  • p

    Paul Woitaschek

    06/25/2018, 1:40 PM
    @jw Why did you write in the readme discussion, that the library is not intended to be used?
  • j

    jw

    06/25/2018, 1:41 PM
    Because it belongs inside Dagger
  • j

    jw

    06/25/2018, 1:41 PM
    So you don't have to do the module nonsense
1...535455...131Latest