https://kotlinlang.org logo
Channels
Powered by
#squarelibraries
  • p

    pniederw

    08/15/2018, 3:58 AM
    same problem in kotlinpoet
  • e

    evanchooly

    08/15/2018, 11:13 PM
    i actually just hit a similar problem trying to return a type like 
    Foo<Bar, List<String>>
  • e

    evanchooly

    08/15/2018, 11:14 PM
    i can create the 
    List<String>
    just fine but the nested 
    Foo<List<String>>
    eludes me
  • j

    jw

    08/15/2018, 11:18 PM
    it's just the same trick, a parameterized type name where foo is the raw type and list<string> is the parameter
  • e

    evanchooly

    08/15/2018, 11:20 PM
    so I have a 
    ClassName
    Foo and I do something like this: foo.parameterizedBy(Boo).plusParamater(listString)
  • e

    evanchooly

    08/15/2018, 11:20 PM
    more or less
  • j

    jw

    08/15/2018, 11:20 PM
    Foo::class.parameterizedBy(List::class.parameterizedBy(String::class))
  • e

    evanchooly

    08/15/2018, 11:24 PM
    So in my case i already have a 
    ParameterizedTypeName
    and I need to add that 
    List<String>
    to it.
  • e

    evanchooly

    08/15/2018, 11:25 PM
    so something like a 
    Foo<Bar>
    + 
    List<String>
    --> 
    Foo<Bar, List<String>>
  • j

    jw

    08/15/2018, 11:28 PM
    i see
  • j

    jw

    08/15/2018, 11:28 PM
    apparently there's a plusParameter function
  • j

    jw

    08/15/2018, 11:28 PM
    looks like it takes a ClassName and not a TypeName. probably copy/paste bug. want to send a PR?
  • e

    evanchooly

    08/15/2018, 11:30 PM
    sure. i was actually just testing that now. 🙂
  • e

    evanchooly

    08/15/2018, 11:33 PM
    also, i just found that 
    ClassName.parameterizeBy()
    takes a 
    vararg TypeName
    which gets me what I want.
  • e

    evanchooly

    08/15/2018, 11:34 PM
    i still think that 
    plusParameter()
    is a typo so i’ll put together a PR for you.
  • j

    jw

    08/15/2018, 11:35 PM
    set the channel topic: Discussions and questions for projects on http://github.com/square
  • e

    evanchooly

    08/15/2018, 11:46 PM
  • e

    evanchooly

    08/15/2018, 11:46 PM
    CLA signed and submitted.
  • e

    evanchooly

    08/16/2018, 12:09 AM
    also, on 
    FileSpec.addImport()
    what’s with the 
    names
    parameter? if I have a 
    ClassName
    representing a FQCN, why can’t I just pass that in?
  • e

    evanchooly

    08/16/2018, 12:09 AM
    am I missing something?
  • e

    evanchooly

    08/16/2018, 12:11 AM
    checks the docs
  • j

    jw

    08/16/2018, 12:18 AM
    you should never have to call addImport with a ClassName
  • j

    jw

    08/16/2018, 12:18 AM
    imports for type references are added automatically
  • e

    evanchooly

    08/16/2018, 12:21 AM
    yeah. i was trying to shortcut a mild flaw in my code. so clearly i need to work a little harder here. 🙂 thanks.
  • j

    julioyg

    08/16/2018, 2:03 PM
    Hi 👋 is there any plans to add this to the gson converter or should we just manually add that factory? Add Kotlin Unit Converter https://github.com/square/retrofit/issues/2329
  • j

    jw

    08/16/2018, 2:10 PM
    it will never be added to a converter for a specific serialization library
  • j

    jw

    08/16/2018, 2:10 PM
    if you have 
    Unit
    somewhere in your JSON model you should register your own Gson TypeAdapter to handle that
  • j

    jw

    08/16/2018, 2:11 PM
    if you are just wanting to use 
    Unit
    for the body type to prevent calling your serialization converter then you should just copy that into your codebase and register it with Retrofit
  • j

    julioyg

    08/16/2018, 2:18 PM
    thanks a lot, for the second
  • j

    jw

    08/16/2018, 2:20 PM
    it's slightly too small to warrant its own artifact
1...565758...131Latest