Channels
#squarelibraries
- b
bdawg.io
08/20/2018, 6:40 PMIs that not feasible then in retrofit2
since2.4
would require multiple CPS entries on the service?suspend - j
jw
08/20/2018, 6:54 PMno it works fine, we're just not sure it's worth introducing an extensible mechanism for. - j
jw
08/20/2018, 6:55 PMi'll probably do the same trick I did with
support and special-case it for Kotlin coroutinesUnit - l
louiscad
08/20/2018, 6:55 PMI'd love to be able to alpha/beta test it! - e
evanchooly
08/30/2018, 2:31 AMis there support in kotlinpoet for this:@field:[Nullable Inject(optional = true)] - e
evanchooly
08/30/2018, 2:31 AMi’m not seeing. not sure it’s there… - j
jw
08/30/2018, 2:39 AMYou don't need that syntax. That's just an optimization for two annotations each with a field use-site target. - e
evanchooly
08/30/2018, 2:39 AMi was just considering that actually. that’s how i’ll parse it out, too. - j
jw
08/30/2018, 2:40 AMKotlinPoet might eventually output that syntax, but it's not going to have an API to support it - j
jw
08/30/2018, 2:40 AMIt'll do it when there's more than one annotation with the same use-site - j
jw
08/30/2018, 2:41 AMFeel free to file a feature request for that behavior - e
evanchooly
08/30/2018, 3:08 AMi don’t need it as such. i’m parsing code that has it and trying build the same-ish kotlinpoet structure. but I can just create multiple `AnnotationSpec`s and and them to the property - j
jw
08/30/2018, 3:26 AMAh, got it - e
evanchooly
08/30/2018, 3:54 AMi have to say, i’m really happy i switched to kotlinpoet. when adding features to my parser, I don’t also need to add features to the generator. pretty much everything I’ve needed has already been there.👍 3 - j
jw
08/30/2018, 3:55 AMWell please let us know when you do run into things! - e
evanchooly
08/30/2018, 4:01 AMabsolutely. - e
evanchooly
08/31/2018, 4:07 AMso
only targets parameters but should also be able to target properties. at least those in constructor parameters. i’m not sure there’s a way in kotlinpoet’s api to restrict that but i’ll poke around.VARARG - e
evanchooly
08/31/2018, 5:00 AMhere’s the class i’m trying generate: - e
evanchooly
08/31/2018, 5:00 AM-.kt - e
evanchooly
08/31/2018, 5:02 AMif i create the property and then set the initializer to the name so that it appears as a ctor param, i get an error when I try to add that default value via
field on `PropertySpec.Builder`:initializer()class Factory(val type: String = "red") - e
evanchooly
08/31/2018, 5:03 AMany ideas on how to fix that? it looks like an API bug to me but perhaps there’s a part of the kotlinpoet api i haven’t seen yet. - e
evanchooly
09/01/2018, 2:18 AMhrm. no luck prodding the api. - e
evanchooly
09/01/2018, 2:18 AMi’ll file a bug. - e
evanchooly
09/01/2018, 4:20 AMle sigh. figured out it out thanks to a helpful bug commenter. 🙂 - e
egorand
09/01/2018, 3:14 PMmight be something we should document - e
evanchooly
09/01/2018, 4:04 PMyeah. it’s non-obvious that it would go on the parameter. same with
. the implicit split between parameter/property on the constructor is a little big magic that isn’t quite so obvious at first glance.VARARG - h
hmole
09/03/2018, 7:43 AMIs there plans to add
to moshi for parsing json without producing extra objects when you want to get value as a string(array or object)?JsonReader.readRawJsonValue() - j
jw
09/03/2018, 7:45 AMYes - h
hmole
09/03/2018, 7:47 AMIssue I can track? - p
Paul Woitaschek
09/03/2018, 7:49 AM