Channels
#squarelibraries
- e
eric
11/13/2018, 5:27 PMDoesn't matter. That's just for the compiler. The parameterization is redundant in this case.👍🏼 1 - h
hmole
11/13/2018, 5:35 PMDoes Moshi 1.8 closes this issue? https://github.com/square/moshi/issues/675. I see it in the milestone, but no
onreadJsonString
.JsonReader - e
eric
11/13/2018, 5:36 PMThe issue is still open. Not released in 1.8. - e
eric
11/19/2018, 2:29 AMyep, in the moshi-adapters artifact - h
hmole
11/19/2018, 8:09 AMShould probably include it in the mainREADME.md - d
dave08
11/25/2018, 5:57 PMIs there a way to have Okio 2.1 read the same source (OkHttp response body) in two ways: 1) as an md5 (+ appending a string at the end, to be included in the md5), 2) for use in a Moshi JsonReader? Like some kind of
or buffer?peek - d
dave08
11/25/2018, 6:08 PMThe source is not so big, I don't mind it being read in memory, but ByteString can't be appended to for (1), and can't be used as a source for (2)...? - j
jw
11/25/2018, 6:12 PMA HashingSource is passthrough, right? So you should just need to wrap the source with it before passing to Moshi and then read the hash at the end👍🏼 1 - d
dave08
11/25/2018, 6:22 PMHow could I add the string to the end of the HashingSource (without being in the Source I provide to Moshi)? I need the md5 done on the (Source + "..."), but Moshi should get the Source without the extra string appended. @jw - d
dave08
11/25/2018, 6:25 PMI found I could
at the BufferedSource, but how could I append to it before passing it to the HashingSink? Or is there still a way to do this with a HashingSource?peek() - j
jw
11/25/2018, 6:26 PMAh I see. Interesting - d
dave08
11/25/2018, 6:35 PMI guess that means it's not possible? 😕 - j
jw
11/25/2018, 8:19 PMIf they're small you can definitely fully buffer them - j
jw
11/25/2018, 8:19 PMRead a ByteString from the original source and then create two new Buffers writing it - j
jw
11/25/2018, 8:20 PMThen appending your magic string to the one and handing to the hasher and Moshi respectively - d
dave08
11/26/2018, 11:19 AMHow do you create a buffer on top of ByteString? There's no such extension function as far as I've looked... 🤔 - j
jw
11/26/2018, 5:17 PMBuffer().write(theByteString)👍🏼 1 - d
dave08
11/27/2018, 10:59 AMI was looking for
, but it makes more sense to write it to the buffer...theByteString.buffer() - d
dave08
11/27/2018, 1:53 PMCould it maybe be useful to have:
?fun String.buffer() = Buffer().writeUtf8(this) - d
dave08
11/27/2018, 1:55 PMAnd same for
...ByteString - j
jw
11/27/2018, 1:57 PMThe ownership model there is weird. It would have to be named toBuffer(), but I don't think it's a common case where you're only writing a single string/byte string to a buffer - d
dave08
11/27/2018, 1:59 PMIn tests and Moshi JsonReader's it comes in handy 🙂 - d
dave08
11/27/2018, 2:01 PMAnd anyways, it has to be imported... so it's clear where it's coming from, and I'm not sure there's too many other types of buffers around in the same project to have conflicts.. - d
dave08
11/27/2018, 2:03 PMJsonReader can have a file, but no String... so at first I had to:JsonReader.of(response.byteInputStream().source().buffer()) - j
jw
11/27/2018, 2:03 PMWe already have a buffer extension and it's for buffering a source or sink - j
jw
11/27/2018, 2:03 PMIf you want to create a buffer with a string or bytestring consider a top-level function named Buffer to act like a constructor - d
dave08
11/27/2018, 2:06 PMYou mean
, that would also clear up the ownership model, good idea!fun Buffer(input: String) = Buffer().writeUtf8(input)👍 1 - d
dave08
11/27/2018, 2:07 PMBut you still think even that's not worth including in the lib? - b
bdawg.io
11/27/2018, 6:21 PMI like how clean the okio apis are. You just flood the okio API if add every possible option unless you make it the
extensiontoBuffer - e
egorand
11/29/2018, 6:28 PM