I also have a bunch of extension functions for JsonReader... like

writeObject { ... }

and

nextLongOrNull()

etc...

Issues are the best place to discuss

I think we'd be open to some of the JsonReader/JsonWriter ones

Especially as a Kotlin rewrite grows closer

I'll try to remember open an issue tomorrow with a gist of some of those functions, thanks for the great work on all these libs btw!

Here it is: https://github.com/square/moshi/issues/785

No real blocker

I’m struggling to get

moshi-kotlin

working properly. I finally got it Proguarding correctly (I think), but now I’m getting reflection crashes on my models. I’m able to work around it by providing defaults for all the constructor parameters. Is this just a requirement of using

moshi-kotlin

? The stack trace for the crash I’m experiencing:```kotlin.reflect.jvm.internal.KotlinReflectionInternalError: This callable does not support a default call: public constructor Session(@com.squareup.moshi.Json token: kotlin.String?, vehicle: com.company.driver.entities.Vehicle?, driver: com.company.driver.entities.Driver, @com.squareup.moshi.Json latestDvir: com.company.driver.entities.Dvir?, preferences: kotlin.collections.List<kotlin.string> = ..., @com.squareup.moshi.Json lmKey: kotlin.String?) defined in com.company.driver.entities.Session[DeserializedClassConstructorDescriptor@f1c45f0] at kotlin.reflect.jvm.internal.KCallableImpl.callDefaultMethod(KCallableImpl.kt:153) at kotlin.reflect.jvm.internal.KCallableImpl.callBy(KCallableImpl.kt:110) at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:104) at com.squareup.moshi.JsonAdapter$2.fromJson(JsonAdapter.java:137) at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:45) at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:27) at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:223) at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:121) at okhttp3.RealCall$AsyncCall.execute(RealCall.java:206) at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) at java.lang.Thread.run(Thread.java:764)```

Post your Kotlin model class?

Session_kt.kt

@eric I’ll admit that I don’t entirely understand everything going on in my proguard, so that could be the culprit if you’re unable to reproduce with just the model and

moshi-kotlin

Is it intentional that JavaPoet generates

public abstract static

rather than

public static abstract

?

I like that JavaPoet enforces an order, just not this order. 🙂

I believe the order is based on the

Modifier

enum of the JDK and whatever order it defines

(that link doesn't contain the order)

seems I was wrong and the preferred order is

public abstract static

so all good, will update my tests accordingly

👍

I think I’ve discovered that somehow my Proguard is still not correct. Without it, all my JSON is parsed without issue, but with it, I’m experiencing:

kotlin.reflect.jvm.internal.KotlinReflectionInternalError: Could not compute caller for function: public constructor DriverStatsResponse(summary: com.company.driver.entities.Summary, events: kotlin.collections.List<com.company.driver.entities.Event>) defined in com.company.driver.entities.DriverStatsResponse[DeserializedClassConstructorDescriptor@9293a] (member = null)

Which makes this a non-kotlin issue

Hi guys, I'm having an issue with

kotlinpoet

. Basically I am doing

myAnnotatedInterface.enclosedElements[0].asType().asTypeName()

and it is giving me an error:

Unexpected type mirror: ()java.lang.String

. Am I doing something wrong? Why is this

()

before the type added? Of course this is just an example, but it's returning me this error everywhere I use

myType.asTypeName()

EDIT: seems like it's (kinda) correct when using interfaces

for now i just write the codeblock into a .kts file.. and everything except the imports works

I can see that there is

wire-kotlin-generator

in https://github.com/square/wire project, is it WIP or I can somehow use it in my app?

You can use the snapshot version

feel free to report any issues you encounter

is there actually a problem with jsr305, as long as libraries using it don't embed it or declare a dependency on it?

Sorry for the off-topic question, but I was sure somebody in this room knows the answer. 🙂

Hello, say I just generated an enum class, how would I generate the companion object of that enum together with functions so clients can call

MyEnum.myFunction(...)

Got it searching readme for “companion”

Does retrofit expect converters to have finished converting by the time a user receives the result of a

response.body()

call? (ie, could I have a rendezvous channel type configured for moshi to lazily convert from a JSON array)