https://kotlinlang.org logo
Channels
Powered by
#squarelibraries
  • j

    jw

    03/04/2020, 6:06 PM
    i'd be opposed to an option. what you're asking is the equivalent of calling a method and passing 
    null
    and having it take the default value which does not seem like something we want to encourage
  • c

    Colton Idle

    03/04/2020, 6:15 PM
    It does seem a bit weird when you phrase it that way and I agree that I think moshi does the right thing by default. If the server sends an explicit null, we should honor that. If they don't want to send it then they should omit it. If anything they'll save some bits across the wire... but I'm working with my own local team which has the weirdest setup that is causing values to sometimes come in as null and others times not to. So it's hit and miss, we're the only platform that has these issues, and I don't want to put ? next to every field in every class of 100+ files. I would really appreciate if you were able to experiment with it, but no biggie if you can't. Just wanted to sanity check if my code above was obviously wrong to anyone and if there was any chance moshi would do/provide this since it does seem to be a common use case people are coming across.
  • b

    Brendan Weinstein

    03/10/2020, 2:41 AM
    Implemented a small feature from scratch and for the networking I defined suspend functions in a retrofit interface. When testing the feature with airplane mode enabled I had a crash from an uncaught 
    UnknownHostException
    . I tried to find a clean way to gracefully handle this without ending up with overly nested try-catch logic. What I ended up doing was defining a `CoroutineExceptionHandler`:
    Copy code
    val handler = CoroutineExceptionHandler { coroutineContext, throwable ->
        if (throwable is UnknownHostException) {
            _state.value = _state.value!!.copy(type = StateType.NO_NETWORK)
        } else {
            throw throwable
        }
    }

  fun onButtonTap() {
    viewModelScope.launch {
      val response = getSomethingFromNetwork()
      if (response.isSuccessful) {
        _state.value = _state.copy(SUCCESS_FETCHING_SOMETHING)
      }
      _state.value = _state.copy(ERROR_FETCHING_SOMETHING)
    }
  }
    Just curious to get folks' feedback to how to best handle an UnknownHostException when defining a network call with suspend functions and retrofit. I am also curious why this exception is thrown as opposed to returning a specific error type. Is it just a remnant from designing libraries for java-land? Or is it still idiomatic to throw an UnknownHostException as a kotlin library?
  • j

    jw

    03/10/2020, 2:42 AM
    any IOException may be thrown
  • p

    Paul Woitaschek

    03/10/2020, 7:23 AM
    I have an inline function that takes a body and catches IoExceptions and HttpExceptions and transforms the exception to data. That class then has a fold function you can use if necessary
  • b

    Brendan Weinstein

    03/10/2020, 9:36 PM
    @Paul Woitaschek would you mind sharing a code sample?
  • p

    Paul Woitaschek

    03/10/2020, 10:40 PM
    @Brendan Weinstein I can't share my implementation but here is some pseudo code which should let you get the idea: https://gist.github.com/PaulWoitaschek/75c0e24e84c016049e072c0b1d45c54d
    👍 1
  • j

    jw

    03/10/2020, 10:43 PM
    You can already use Response to avoid HttpExceptions and I worked on adding Result today
  • j

    jw

    03/10/2020, 10:44 PM
    An inline class will never be feasible though, unless you're referring to Java's inline class proposal implementation as part of project Amber which supports multiple fields in an inline type.
  • c

    coletz

    03/12/2020, 11:33 PM
    Hi guys, I am trying to execute a task on gradle just after sqldelight completes its execution, but I can't find the sqldelight tasks (./gradlew tasks returns all of them, but running tasks.forEach(::println) doesn't show sqldelight tasks)... Is this caused by the fact that sqldelight tasks are added later by the plugin?
  • c

    Colton Idle

    03/13/2020, 2:59 AM
    Jake Wharton [JW]  [11:22 AM] Btw we built literally what you asked for once: https://github.com/square/dagger-intellij-plugin
    Does anyone use this plugin in AS 4.0? I just installed it and I unfortunately don't see the little daggers in my gutter.
  • c

    Colton Idle

    03/17/2020, 3:26 PM
    Kind of moshi related. Is there any way to quickly inspect and see if kotlin reflect is being included in my aab? I want to make sure I'm using the codegen version correctly.
  • r

    Ray Ryan

    03/20/2020, 7:38 PM
  • g

    ghedeon

    03/31/2020, 7:52 PM
    I'm surely missing something but does Retrofit support kotlinx contextual serializers? 1. Works as expected
    Copy code
    Json {
        serialModule = serializersModuleOf(
            mapOf(Foo::class to FooSerializer)
        )
}.parse(json)
    2. 
    Can't locate argument-less serializer for class Foo.
    Copy code
    Retrofit.Builder()
             .addConverterFactory(Json{ <same configuration> }.asConverterFactory("application/json".toMediaType()))
 ...
    UPD. Seems like it's not supported yet, reported: https://github.com/JakeWharton/retrofit2-kotlinx-serialization-converter/issues/18
  • m

    myanmarking

    04/04/2020, 1:34 PM
    hello. i would like to create an interceptor for retrofit to add response headers to my returned object automatically for specific requests. is that an easy task, and there is any doc on that?
  • m

    myanmarking

    04/04/2020, 1:35 PM
    i would expect not because intercepting the response and building the results happens on different layers
  • c

    Colton Idle

    04/04/2020, 4:38 PM
    Not sure if anyone can help out here. I followed Matt Precious' droidcon talk. Dagger noob as well, so maybe someone can point out whether I completely botched this debug drawer. It's not too many lines of code but someone I found a broken scenario. https://github.com/ColtonIdle/DrawerFailure
  • m

    myanmarking

    04/04/2020, 5:57 PM
    i cannot manage to make sqldelight upgrate my tables at runtime. schema files are generated with the script, but when i launch the app, the new tables aren't there
  • m

    myanmarking

    04/04/2020, 5:58 PM
    do i need to specify anywhere the updated version nr ?
  • a

    alec

    04/04/2020, 6:00 PM
    did you write migrations?
  • m

    myanmarking

    04/04/2020, 6:00 PM
    yes. i got a file 1.sqm
  • m

    myanmarking

    04/04/2020, 6:01 PM
    using the default config
  • m

    myanmarking

    04/04/2020, 6:01 PM
    Screenshot 2020-04-04 at 19.00.50.png
  • a

    alec

    04/04/2020, 6:01 PM
    android?
  • m

    myanmarking

    04/04/2020, 6:01 PM
    actually just this
  • m

    myanmarking

    04/04/2020, 6:01 PM
    Copy code
    sqldelight {
    Database {
        schemaOutputDirectory = file("src/main/sqldelight-schemas")
    }
}
  • m

    myanmarking

    04/04/2020, 6:01 PM
    yes, android
  • a

    alec

    04/04/2020, 6:03 PM
    if you set a breakpoint inside of the 
    migrate
    method does it get called? https://cashapp.github.io/sqldelight/1.x/runtime/com.squareup.sqldelight.db/-sql-driver/-schema/
  • a

    alec

    04/04/2020, 6:03 PM
    if yea i would step through there to try and find out whats going on
  • m

    myanmarking

    04/04/2020, 6:03 PM
    i'll check. thanks!
1...848586...131Latest