Also with a bound of

?

WildcardType

there's like subtypeOf and supertypeOf factories

Perfect, thanks

Although I gotta say this is rather clunky:

ParameterizedTypeName.get(ClassName.get(Function::class.java), WildcardTypeName.supertypeOf(TypeVariableName.get("T")), WildcardTypeName.subtypeOf(TypeVariableName.get("U")))

types are complex. you should be sharing the

TypeVariableName

instances since they'll also need to be added to the enclosing

MethodSpec

Does it matter that they are different instances if the underlying type name is the same? They’re both “U”. The reason I’m not sharing the instance is because I wanted to keep my method chain for the builder compact

not functionally, but you're contributing to the bloat by not sharing some of these instances. that code could easily be

ParamaterizedTypeName.get(functionType, supertypeOf(typeVarT), subtypeOf(typeVarU))

SqlDelight / Android I didn't know that foreign keys are disabled by default. So my app was released without foreign key checks ON. I can guarantee the data integrity. Is it ok to turn on the foreign keys in the

onConfigure

for an existing database? After I have turned it on, the app is not behaving correctly anymore and I see errors in the logs

Error: Undeliverable exception received, not sure what to do android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method)

we have ours in the

onOpen

callback

it should be fine to execute it on an already running db, i don’t think that causes an integrity check

tried it also in the

onOpen

but getting same errors. I am calling this method

setForeignKeyConstraintsEnabled

and I also tried the pragma query

does the same happen for a fresh db? is there anything else in the logs

what you’re doing should work as far as i know, that error seems more like some platform android stuff than sqldelight-specific

Retried in

onOpen

and it is working for both cases now... Thanks a lot

@Zac Sweers You blocked me on Github don't know why so I can't answer on your pr and you don't see my messages there 🙂

Task shadowJar ran too late, check the moshi codegen code it will still reference the non relocated one.

I see correct mapping in my PR

I see com.squareup.kotlinpoet it should be come.squareup.moshi.kotlinpoet due to relocate no?

not all of kotlinpoet, only its metadata artifacts

the rest of kotlinpoet is stable

ok so it shadowed too much but did not update source code as the kapt crash did reference the non relocated one.

Anyway happy whatever solution is found 🙂

So quickly tested this morning and your last version works nicely. But I have a small spotless/ktlint issue on Windows I need to add targetExclude("**/generated-sources/**/*.kt") else it fails on generated code on Windows but not on CI. Any idea why?

Any best practices for using the Multi-Module feature in SqlDelight. The idea is we have multiple apps that share some parts of the our business and data layer: 1. Where would you place the sqm files. How would you deal with different schema versions because you have different apps? 2. Can we have the different modules in separate repos? How would this affect the schema version? Wouldn't be better to manage the migration outside the module in this case?

if you have separate repos i would recommend having separate databases entirely

otherwise migrations are going to get insane

if you do multi-module single-database in one repo, we have all our sqm files in the top-most module with sqldelight applied

so that we dont accidentally have two migration files for the same version