Hi, I'm not able to use upsert with sqldelight.

// Gradle file
sqldelight {
    database("Database") {
        dialect = "sqlite:3.24"
        packageName = "com.myapp.kmm.database"
    }
}

// .sq File
upsert:
INSERT INTO Organization VALUES ?
ON CONFLICT(id) DO
UPDATE SET name=excluded.name, code=excluded.code;

// Error when running the app
E/SQLiteLog: (1) near "ON": syntax error

Can you file an issue on github

Oh it’s a runtime error

Is your app running SQLite 3.24 or above?

I'm using Sqldelight: 1.4.2

SQLDelight doesn’t really effect what version of SQLite your app runs with

Ah!

I didn't understood that, I thought that the dependencies where going to be added automatically. Ok, I'll dig into that. Thx.

Np

Hum, I have

I don't know how to change that.

This is not sqlite version see https://developer.android.com/reference/android/database/sqlite/package-summary for version by Android version. Don't expect upsert support on Android 🙂

-_- I totally forgot this documentation AND the version that I'm using. My Android APP is API 21 minimum... So I get it. Thank you a lot.

^^

hello. a question i did not find in the docs. Can moshi type converters be instance classes? Or it must be static ?

hm, actually sorry. In the examples, its instance class. my bad. Maybe this changed and i didnt noticed 😛

If anyone familiar with moshi feels like enlightening me as to why I'm wrong here 😭 https://stackoverflow.com/questions/63986042/moshi-custom-factory-not-working-as-expected-losing-type-data-as-i-try-to-remov

I don’t think there is anything surprising here. See

readJsonValue()

- https://github.com/square/moshi/blob/bf72ce8ade0db490136834096e0881d17c87e20a/moshi/src/main/java/com/squareup/moshi/JsonReader.java#L525-L526. You read a number which is converted to a double and passed to be read by a delegate as a string. You need to create a separate adapter that is capable of parsing doubles that will be strings and annotate properties that are of interest. I’m not sure what you expect from

@ToJson

, so I left it as is.

@Retention(RUNTIME)
@Target(VALUE_PARAMETER, FUNCTION)
annotation class NumberString

object NumberStringAdapter {
  @ToJson fun toJson(@NumberString number: String): String {
    return number
  }
  
  @FromJson @NumberString fun fromJson(number: String): String {
    return number.toDoubleOrNull()?.toLong()?.toString() ?: number
  }
}

@MiSikora so I should have another adapter in my chain of adapters, but make sure that this one comes after my

DefaultIfNullFactory

?

Yup

Has anyone tried using moshi with IR? I don't know why that wouldn't work but IR can break things in all kinds of fun ways. cc @Zac Sweers

@Zach Klippenstein (he/him) [MOD] already got a response from Zac here https://github.com/square/moshi/issues/1221

@MiSikora so it's basically unlikely that that I could write a single adapter/factory that would properly just strip nulls from my code... right?

You could traverse recursively a map that is returned by

readFromJson()

, check for doubles and convert them to strings in a long format but you can lose information this way on some of the actual doubles and generally seems like a bad idea. Using a separate adapter for this type of conversion seems correct. That’s basically main purpose of custom annotations in Moshi

Interesting. Alright. It seems like I'll have to go that route. The way I interpreted some of the comments from Zac on some moshi issues, it seemed like it'd be possible to do this in one single adapter.

It is possible but needlessly complicated. It’s much better to be explicit about your intentions with annotations

Lost me there. "It’s much better to be explicit about your intentions with annotations"

How so? It’s better to annotate your param with i.e.

@NumberString

in order to make sure that it will be parsed differently than to rely on some magic inside a different adapter that will act on all of the numbers.

Gotcha. I was just asking for clarification by saying "lost me there", no disagreeing. 😄 Thanks for your time @MiSikora

Hello! Is there any Intecerptor in OkHttp or Retrofit2 that let me retry an api call N times? And until then it doesn't update the UI?