kotlinlang #strikt

fun <T : Any> Assertion.Builder<T>.isOneOf(vararg expected: T): Assertion.Builder<T> =
		assert("is one of %s", expected) {
			when {
				expected.contains(it) -> pass()
				else -> fail()
			}
		}

robfletcher

11/26/2018, 5:19 PM

Yep.

dave08

11/26/2018, 5:21 PM

So then I do:

all { isOneOf("this", "that") }

, but I think there could still be some short cut

containsOneOf

and the console printout is too verbose using this workaround...

robfletcher

11/26/2018, 5:39 PM

That should be easy to implement.

dave08

11/27/2018, 4:32 PM

How do I match an amount of collection elements that match the predicate?

Copy code

fun <T : Iterable<E>, E> Assertion.Builder<T>.only(expected: Int, predicate: Assertion.Builder<E>.() -> Unit): Assertion.Builder<T> =
		compose("only $expected elements match:") { subject ->
			subject.forEach { element ->
				get("%s") { element }.apply(predicate)
			}
		} then {
                        // I need the amount of assertions that passed here... anyPassed doesn't help here...
			if (anyPassed) pass() else fail()
		}

@robfletcher

robfletcher

11/27/2018, 5:01 PM

No way right now. I can add that to the API though

dave08

11/27/2018, 5:02 PM

Maybe

failedCount

and

successfulCount

CompoundAssertion

would help too 🙂

robfletcher

11/27/2018, 5:03 PM

The workaround might be to do

Copy code

expectThat(list)
  .get { it.filter(predicate) }
  .size
  .isGreaterThan(2)

robfletcher

11/27/2018, 5:03 PM

If I understand what you’re doing correctly

robfletcher

11/27/2018, 5:04 PM

I think I’ll add

filter

to Strikt’s API for

Assertion.Builder<Collection<T>>

mkobit

11/27/2018, 5:05 PM

that was one thing i always liked in AssertJ - the

atLeast

and other quantitative assertions for collections

robfletcher

11/27/2018, 5:06 PM

Easy to add those. The focus so far has been on getting the API right.

dave08

11/27/2018, 5:07 PM

Yup but

only

meaning

isEqualTo

not

isGreaterThan

. Filter would certainly be great! But what do you think about

failedCount

and

successfulCount

CompoundAssertion

robfletcher

11/27/2018, 5:08 PM

I’ll add them

👍🏼 1

robfletcher

11/27/2018, 5:09 PM

IIRC they’re on the internal API

dave08

11/27/2018, 5:10 PM

I'm also using

filterIsInstance

before my matching pretty often (I have a list of objects with a common base class, in the same list and making assertions on it).

dave08

11/27/2018, 5:18 PM

If I do a

get

after

isA

failed in an

expectThat() { }

block the tests crash with

ClassCastException

instead of reporting the errors. Is this by design @robfletcher?

robfletcher

11/27/2018, 5:18 PM

No. Can you give me a specific example?

christophsturm

11/27/2018, 5:19 PM

i had that too but forgot about it

dave08

11/27/2018, 5:22 PM

Copy code

data class Test(val a: String)
		data class Test2(val b: String)

		val i = Test("this")

		expectThat(i) {
			isA<Test2>().get { b }.isEqualTo("that")
		}

christophsturm

11/27/2018, 5:24 PM

i think its not related to the get because the isA should already fail

dave08

11/27/2018, 5:25 PM

It doesn't catch the exception and give a neat report... it just crashes all the tests and gives a java stacktrace...

robfletcher

11/27/2018, 5:25 PM

Ok that’s a bug

dave08

11/27/2018, 5:27 PM

Copy code

at strikt.internal.AssertionBuilder.get(AssertionBuilder.kt:64)
	at strikt.api.Assertion$Builder$DefaultImpls.get(Assertion.kt:233)
	at strikt.api.DescribeableBuilder$DefaultImpls.get(DescribeableBuilder.kt)
	at strikt.internal.AssertionBuilder.get(AssertionBuilder.kt:10)

dave08

11/28/2018, 12:20 PM

I get this on the assertThat....

dave08

11/28/2018, 12:21 PM

What did I do wrong? @christophsturm