Channels
#strikt
- r
robfletcher
03/11/2019, 8:35 PMah, okay. Just having the strings show up would be a start - r
robfletcher
03/11/2019, 8:35 PMI should probably make the orchid module depend on the ones it’s generating docs for - c
Casey Brooks
03/11/2019, 8:38 PMYou really only need to add those modules to the Orchid classpath if you want to actually use them in an Orchid plugin or something. The
arg passed to Dokka, which will make the external lib strings show up, isn’t the actual runtime classpath, it’s just a generic arg that Dokka does some magic with-classpath - r
robfletcher
03/11/2019, 8:43 PMgotcha - r
robfletcher
03/11/2019, 8:44 PMI keep forgetting it’s not using the dokka task from those other modules - c
Casey Brooks
03/11/2019, 8:49 PMYeah, tying Orchid into those Gradle tasks would prevent it from being useful from Maven or other build tools. Initially, that’s how it worked with Javadoc, but it was just a huge pain and not very flexible - c
Casey Brooks
03/11/2019, 8:49 PMI’ve created an issue to track this, thanks for pointing it out! https://github.com/JavaEden/Orchid/issues/237 - r
robfletcher
03/11/2019, 8:56 PM👍 - r
robfletcher
03/11/2019, 9:07 PMFor the complexity of the Strikt API I think just static text is sufficient really, the benefit of the external links is minimal - r
robfletcher
03/12/2019, 5:44 AMTook some fiddling but I got it working https://github.com/robfletcher/strikt/commit/3bc0ae0bceafeda2b6b4369b85783e2ddfa0db63🎉 1 - d
dave08
03/12/2019, 6:30 PMHi any way to assert if a value is in a map and at the same time assert on its value? - r
robfletcher
03/12/2019, 6:32 PMThe closest thing is
but it’s just an equality check on key and value, if you want to do a different assertion on the value you can’t do it in a single step right nowhasEntry - r
robfletcher
03/12/2019, 6:33 PMbut you can do e.g.assertThat(aMapOfStringToInt).get("foo").isNotNull().isGreaterThan(3) - r
robfletcher
03/12/2019, 6:34 PM
is the simple form, but it’s equivalent to justassertThat(aMap).hasEntry("foo", 3)
on the valueisEqualTo - d
dave08
03/12/2019, 6:34 PMI tried, I have a Map<String, Map<String, Any>>... so the second get doesn't seem to work... - d
dave08
03/12/2019, 6:35 PMCopy codeexpectThat(result) .get("key1") .get("nested key") .isA<Collection<String>>() .containsExactly("thumbnail") - r
robfletcher
03/12/2019, 6:35 PMhmm, that should work. It fails at the
?isA - r
robfletcher
03/12/2019, 6:36 PMor is it failing to compile because
might beget("key1")
?null - d
dave08
03/12/2019, 6:37 PMI got this - r
robfletcher
03/12/2019, 6:38 PMDoes it work if you add
between the 2.isNotNull()
calls?get - d
dave08
03/12/2019, 6:39 PMOk that seemed to do it... - r
robfletcher
03/12/2019, 6:39 PMyeah, it’s because
can returnget(String)
(if the map does not have anything under that key)null - r
robfletcher
03/12/2019, 6:39 PM
then narrows the type by asserting it’s not nullisNotNull - r
robfletcher
03/12/2019, 6:40 PMI should consider widening the target forget - r
robfletcher
03/12/2019, 6:45 PMalthough I’m not sure it really makes sense to support
on aget
mapnull - r
robfletcher
03/12/2019, 6:47 PManother option would be to make
assert that the result is non-null but then you couldn’t dogetexpectThat(aMap).get("foo").isNull() - d
dave08
03/13/2019, 11:40 AMYou could maybe try the second option and name it
like the distinction in Kotlin's standard library...getValue - r
robfletcher
03/13/2019, 1:30 PMYes. I think that’s what I’m gonna do👍🏼 1 - r
robfletcher
03/13/2019, 4:42 PMWill be in the next release - r
robfletcher
03/13/2019, 4:43 PM