@ron If you do that, you need to do it everywhere you use that PersonModel, so it's throws reusability out the window. You want the ViewModel to know how to construct your Person object.

then how to clean the current model? a new button that sets model.item to null?

If you need that, just do

model.item = null

a window like this usually has two usecases 1) create a new one, 2) update an existing one

yes that is what I thought

If you never need to contain a null value you can also simplyfy the binding expressions like I showed yesterday.

there is the "new" case that will have the new value

actually this is quite helpfull in my keepasFX thingy

You agree with my implementation, or is there something it doesn't solve for you?

no I agree

Sweet 🙂

I will add this example to the guide

I always felt that the onCommit needed some love

Hehe, no I think it's good if it's used like it was intended 😁

I mean in the guide it needs some love

this example is quite good to show that

Great! Yeah, it's small and self contained and shows everything you need to. We might mention though, that if your ViewModel never need to contain a null object, you can write it much simpler.

I will show that too

Actually, you can always write it like this, the null check was not needed at all:

@User uploaded a file: Untitled

I updated the sample above.

Always use it like that, and you're golden.

I also updated the sample to use

action

instead of

setOnAction

🙂

Pair programming again, back later 🙂

@edvin you should adopt that in the intellij plugin 😉

@edvin we should also not that if you use POJO's the binding is

@User uploaded a file: Untitled

name in this case is a string coming from a java class (Group.java) so it might be null

@ron Does it mater if the

SimpleStringProperty

contains null?