I will try them out tomorrow, very close to bedtime here

Same here. Good night!

@edvin Cool! Try tomorrow too. Just returned home

@borboss Great 🙂

It might also be possible to make the pojo bindings write back into the domain object if it's mutable. Will look into that tonight.

@edvin would that be

val name = bind(Customer::getName, Customer::setName)

? makes it explicit what is being called

@ron We could, but @gtnarg already made it so that specifying the getter would locate the setter automatically in other places in the framework, so we should probably use the same syntax here.

we can play with it

it works with a JavaPerson and an onCommit

Great!

I like this new syntax 🙂 More in line with table column builders as well.

@edvin how to reset the model in this case?

@User uploaded a file: Untitled

I would have expected the view be cleared after the item = null

@edvin how to reset the model in general 🙂

@ron That's how you would do it. If it doesn't work I suspect that might be a bug.

Do you have this code in a complete class I could try?

Yeah hold on

@User uploaded a file: Untitled

@User uploaded a file: Untitled

after pressing ok and the onCommit is called I expected the two fields to be cleared

Me too. I try to set a breakpoint inside onCommit, but IDEA doesn't stop on it. This happens quite often. Really irritating.

@ron There is no bug 🙂

Well, only in your code.

hehe

You never assign anything to the javaPersonModels item property. Therefore, when you call

item=null

on commit, it's a no op.

The item is already null, so no rebinding is performed.

If you change it so that it assigns to the item property, it would reset.

@User uploaded a file: Untitled

You're using it a bit weird though, I would expect you to normally put a person inside the itemviewmodel before you start editing.