@nimakro and I did not like it their either 🙂 difference here is the fact that you do a

toString

to set the content

if you have a java class without toString or a normal kotlin class it will print the address (@somethingsomething) instead of the actual content

@ron Well is that not a requirement for using the Properties class everything has to be a String? And i think if we want to keep the syntax

set("key" to "value")

we will not be able to get rid of

Any

?

I usually use the Preferences from java and I store jsonObjects if I have more complex configurations to store

You can now do

set("key" to someJsonObject)

and retrieve it with

config.jsonObject("key")

Same for

jsonArray

and even

jsonModel

can we start thinking (again) about a datadriven treeview? I need it man, I really do 🙂

Yeah, let's have a look after this release.

Writing about the config changes now, brb.

@edvin Is

!Files.exists(parent)

on line 71 in

Component.kt

not unnecessary since

Files.createDirectories()

will only create the dirs if they don't exist?

And by the way I like the

interface Configurable

approach!

@nimakro Let me check 🙂 I just wrote about the features here: https://github.com/edvin/tornadofx/pull/292#issuecomment-291961865

brb

@nimakro There is JSON support now, but I would like to support writing the whole config file as JSON down the line. I have an idea for editable JsonObjects and merging with Map etc, so if it's OK with you, I'll revisit this in a while.

@nimakro Checking

Files.exists

is slightly faster, since it doesn't rely on trying to create a directory and catching an exception. In practice it probably doesn't have any measurable effect though.

@nimakro If you have time to try it and give feedback that would be great! I'll wait with releasing until we're happy with this.

@edvin I think it looks pretty good to me, the documentation is also good. And go ahead with the editable JsonObjects...

Sweet! We should test it a little before I release as well. I've tested it with different situations and in my apps. So far soo good.

@edvin Yeah then we will key the if condition

Yes 🙂

and check for

Files.exists

fist 😉

@edvin I will play with the config a bit probably tonight and some more tomorrow but for now it looks pretty promising 😉

Great! Updating the docs, but holding off until you have tested it a bit.

@nimakro Very happy that you brought this up, and I feel bad for not using your PR as is, but you gave me all the ideas and insight I needed 🙂

@edvin Don't feel bad I like your approach better and like I said, I made that PR so we can discuss stuff and get the best out of it 😀

Thank you 🙂

Did anybody think already of writing builders for the

controlsfx

project? I really use them quite a bit in plain javafx projects. When ever I need to use them with tornadofx it looks ugly.

Same here, it's really annoying to have to break the builder flow to accomodate for them. Should we set up a

tornadofx-controlsfx

integration project?

I think that would be best then we could add the builders as we go

@edvin Do you want to do it in your repo or should I start one?