No, it can't. I test for the player turn of the wanted dragged piece

Yes

You're right

Forgot about this

I commit the change in a matter of minutes

Oh, fantastic!

I will try to get this running with JPro tonight.

Thanks 😄

Commit is pushed 😄

There is a little bug with the hisotry

@loloof64 About the UI code.. You could use the builders to avoid assembling the pieces manually. For example this:

@User uploaded a file: Untitled

I agree 😄

I check if I can make these pieces building better, code cleaner now.

@User uploaded a file: Untitled

The thing you do with

selectedPiecePreviewLine.children[1] = selectedPieceImageView

can be avoided by setting the image value into a property and bind that to an ImageView inside

selectedPiecePreviewLine

.

There is usually no need to create variables for all the ui elements if you do it like this.

I'll check it now

@loloof64 If you want, I could try to rewrite

PromotionDialog

to show you how I would have done it?

Yes. I will take you pull request if you want to 😄

I am open to all clean code suggestions

Cool! I will give that a shot later. It will give you some ideas about how you can structure things more easily. It also makes it much easier to make changes and move stuff around later.

Thanks 🙂

The history feature is very basic

We can only add move to the current position

Otherwise, it starts to be messy

Meanwhile, clicking on a node restore the wanted position

sniff there goes the datadriven treeview 😜 edvin is into chess now 😆

I see lots of improvement potential, not because you did anything wrong, but because you didn't use TornadoFX features and did it the JavaFX way instead. This is very impressive work! With some adjustments this would be a great showcase for TornadoFX!

@ron Haha, nah.. I will for sure devote a little time to this, but this won't take long. It's all pretty well put together.