https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • r

    ron

    04/08/2017, 10:13 PM
    I overlooked that completely
  • e

    edvin

    04/08/2017, 10:14 PM
    Btw, I think 
    val groupsProperty = SimpleObjectProperty(mutableListOf<GroupFX>().observable())
    should be 
    val groupsProperty = SimpleListProperty<GroupFX>()
  • e

    edvin

    04/08/2017, 10:16 PM
    You can also do 
    groups = group.groups?.map { GroupFX(it) }
    instead of what you do in 
    updateGroup
    .
  • e

    edvin

    04/08/2017, 10:17 PM
    Maybe not, that wouldn't be observable, but you can do 
    setAll
    with that.
  • r

    ron

    04/08/2017, 10:18 PM
    but will that recurse?
  • e

    edvin

    04/08/2017, 10:19 PM
    Yes, because you create a new 
    GroupFX
    object, which will call this code for the children of the passed in group.
  • r

    ron

    04/08/2017, 10:25 PM
    it works
  • r

    ron

    04/08/2017, 10:25 PM
    it actually works
    🎉 2
  • e

    edvin

    04/08/2017, 10:25 PM
    Sweet. Now I can go to bed :))
  • r

    ron

    04/08/2017, 10:26 PM
    not with your code 🙂
  • r

    ron

    04/08/2017, 10:26 PM
    with the updateGroup
  • r

    ron

    04/08/2017, 10:26 PM
    now I will check with your code
  • e

    edvin

    04/08/2017, 10:26 PM
    Bed is off then.
  • r

    ron

    04/08/2017, 10:28 PM
    Error:(33, 32) Kotlin: Type inference failed. Expected type mismatch: inferred type is List<GroupFX> but ObservableList<GroupFX>! was expected
  • r

    ron

    04/08/2017, 10:28 PM
    that is with your code
  • e

    edvin

    04/08/2017, 10:29 PM
    Yeah, I said that you needed to use setAll.
  • g

    gtnarg

    04/08/2017, 10:29 PM
    My code above has the setall - for an example
  • e

    edvin

    04/08/2017, 10:30 PM
    Ah, I see Grant already wrote that 🙂
  • e

    edvin

    04/08/2017, 10:31 PM
    Great work. And it seems your data driven implementation is working good, Grant. The one I committed is almost identical to yours 🙂
    🎉 1
  • e

    edvin

    04/08/2017, 10:31 PM
    Good night guys 🙂
  • g

    gtnarg

    04/08/2017, 10:31 PM
    good night 🙂
  • r

    ron

    04/08/2017, 10:31 PM
    Copy code
    00:30:07.603 [JavaFX Application Thread] ERROR ErrorHandler - Uncaught error 
java.lang.NullPointerException: null
	at keepassFX.fxui.model.GroupFX.<init>(model.kt:34)
	at keepassFX.fxui.views.GroupView$root$1.invoke(GroupView.kt:22)
	at keepassFX.fxui.views.GroupView$root$1.invoke(GroupView.kt:19)
	at tornadofx.FXKt.opcr(FX.kt:400)
  • e

    edvin

    04/08/2017, 10:32 PM
    What did you write?
  • e

    edvin

    04/08/2017, 10:32 PM
    groups.setAll(group.groups?.map { GroupFX(it) } ?: emptyList())
    ?
  • r

    ron

    04/08/2017, 10:33 PM
    groups.setAll(group.groups?.map(::GroupFX))
  • r

    ron

    04/08/2017, 10:33 PM
    a wait the empty list
  • e

    edvin

    04/08/2017, 10:35 PM
    But I wonder.. do you really need the property for this observable list? Couldn't you just do 
    val groups = FXCollections.observableArrayList(group.groups?.map(::GroupFX) ?: emptyList())
    ?
  • e

    edvin

    04/08/2017, 10:35 PM
    And remove both 
    groupsProperty
    and the 
    updateGroup
    function alltogether?
  • r

    ron

    04/08/2017, 10:36 PM
    no. because the groups will change when a file is opened
  • r

    ron

    04/08/2017, 10:36 PM
    when the application starts up there are no groups
1...107510761077...2007Latest