@User uploaded a file:

I like nullableParam as it is a clear signal

About result - I could rename

Wizard

to

ResultWizard

and create

open class Wizard : ResultWizard<Any>

so you don't need to specify a type when you don't need it.

Look, a wizard in the wild! 🎉

why? lets first make all this work and you happy about the current state of affairs

maybe we dont need all that

apart from the onResult, that sounds quite cool

Yeah, I think we need that. The caller should be able to tell when the user completes the dialog.

that i agree on, al the other stuff not so much (yet)

now the interesting part comes, I am going to change my EntryModel to have the EntryBuilder in it and the partial commits will call the builder

your onSave as partial commits fits that idea perfectly

@ron Just so I understand you. You want

onResult

- and a type on Wizard?

Or do you just want a callback when the user completes the wizard?

onResult 👍 type on wizard 😢

(there is no thumbs down)

call back when complete

OK. I kind of agree because we have steered clear of types on classes so far.

OK. Checking a few things.

brb

is it correct that the onsave is not called if you use the navigation on the left?

@edvin you had some code in a screencast where you have an editable list? do you still have that code somewhere and if so can I steal it?

@ron do you mean a listview check the todomvc from edvin I think the class is called TodoFragment which is handling the editing

you are right I should look at that

rofl I am stupid, its not a list its a table

@ron That's correct, then you skip save of the current step.

hmmz

@edvin is there not an editable tableview in one of the examples?

@ron Yeah, I think there is. What do you want to edit? You can call

makeEditable()

on most columns to do that, and provide a commit callback via

tableView.onEditCommit

yeah but you cannot add a row like that

No, you would have to add the row first and then enter edit mode.