Channels
#tornadofx
- m
mikehearn
04/18/2017, 6:54 PMi upgraded to 1.7.2 and now my code crashes (i suspect it's incorrect but it stopped working across the upgrade) - m
mikehearn
04/18/2017, 6:54 PMi have something like this - m
mikehearn
04/18/2017, 6:54 PMreturn combobox(model.nearestCity, CityDatabase.cityMap.values.toList().sortedBy { it.description }) { - m
mikehearn
04/18/2017, 6:55 PMwhere model.nearestCity is like - m
mikehearn
04/18/2017, 6:55 PMCopy codeclass NodeDataModel : ItemViewModel<NodeData>(NodeData()) { val legalName = bind { item?.legalName } val nearestCity = bind { item?.nearestCity } - m
mikehearn
04/18/2017, 6:55 PMand NodeData.nearestCity is SimpleObjectProperty(CityDatabase["London"]!!) - m
mikehearn
04/18/2017, 6:55 PMi getjava.lang.IllegalArgumentException: The addValidator extension on TextInputControl can only be used on inputs that are already bound bidirectionally to a property in a Viewmodel. Use validator.addValidator() instead or update the binding. - m
mikehearn
04/18/2017, 6:55 PMinside the combobox i have - m
mikehearn
04/18/2017, 6:55 PMCopy codevalidator { if (it == null) error("Please select a city") else null } - e
edvin
04/18/2017, 7:07 PM@mikehearn I tried to get rid of some trickery we did that was not JDK9 compatible. Maybe I messed up. I will look into this ASAP, probably tomorrow morning 🙂 - m
mikehearn
04/18/2017, 7:07 PMno worries. there's no hurry. i can stick with 1.7.1 for now. as 1.7.3 has the combox fix i'll just skip straight to that - e
edvin
04/18/2017, 7:09 PM@mikehearn Actually, I found the issue. I committed a fix for combobox, but there are other controls that need a similar fix. Will commit the rest of them tomorrow and probably to a quick release. - m
mikehearn
04/18/2017, 7:09 PMgreat - t
thomasnield
04/18/2017, 8:41 PMHave we ever streamlined clipboarding a TableView? - e
edvin
04/18/2017, 8:49 PM@mikehearn If you have a chance to test 1.7.3-SNAPSHOT that would be very helpful. It it works for you, I will release 1.7.3 at once. This will mainly be a bug fix release and it introduces android compatibility. - e
edvin
04/18/2017, 8:52 PM@mikehearn I pushed
(20170418.205128) to https://oss.sonatype.org/content/repositories/snapshots/no/tornado/tornadofx/ now.1.7.3-SNAPSHOT - r
Ruckus
04/18/2017, 9:00 PMI managed to sneak the
property in, since it was an easy one line change 🙂baseColor - e
edvin
04/18/2017, 9:17 PM@Ruckus Hurray! I'm playing a little with the Wizard from plain java to see if it would suck to use it that way. Vanilla JavaFX is missing a Wizard after all, so maybe that would be interesting to some vanilla JavaFX folks. I might sneak in a change or two to accommodate that as well.👍 3 - r
Ruckus
04/18/2017, 9:18 PMThat would be an awesome addition to JavaFX - e
edvin
04/18/2017, 9:19 PMI think so! Wonder how hard it would be to make TornadoFX non-sucky from Java though. - r
Ruckus
04/18/2017, 9:20 PMI have to write vanilla JFX applications for work every now and again, so that could be nice in a library. - e
edvin
04/18/2017, 9:24 PMI think we would need some extra baggage that we don't want to drag around in TornadoFX Core, but a TornadoFX-Java addon could be the way to go.👍 2 - c
carlw
04/18/2017, 9:26 PM@edvin - c
carlw
04/18/2017, 9:27 PMthis broadens the footprint, but maybe you can start exposing the Kotlin code via a Java front-end? - e
edvin
04/18/2017, 9:32 PMHaha, it's working :))🎉 1 - e
edvin
04/18/2017, 9:33 PM@carlw Yes, that's probably the next step. - e
edvin
04/18/2017, 9:33 PMIt needs some java specific adjustments though. This is my complete app: - e
edvin
04/18/2017, 9:34 PM@User uploaded a file: Vanlla JavaFX Wizard App - t
thomasnield
04/19/2017, 12:26 AM@edvin is this possible vanilla JavaFX folks are going to want the wizard in ControlsFX? - e
edvin
04/19/2017, 6:26 AM@thomasnield Yeah, absolutely. It would be rewritten in Java and put in ControlsFX, but I would like to investigate the use of TornadoFX from Java first.