edvin
05/03/2017, 7:37 PMkastork
05/03/2017, 7:38 PMedvin
05/04/2017, 8:04 AMedvin
05/04/2017, 8:04 AMComboBoxBase.required()
validatoredvin
05/04/2017, 8:19 AMInstanceScoped
was a bad idea, it actually makes it hard to instantiate a Wizard and at the same time put data into it's scope. I'm thinking about simply removing it.edvin
05/04/2017, 8:19 AMron
05/04/2017, 8:20 AMedvin
05/04/2017, 8:20 AMnimakro
05/04/2017, 8:47 AMInstancedScoped
I need to read more about scopes yet...so I can't say anything about that...you probably know best so go ahead and do what you think needs to be done 😀 (hoping to know more about the internals soon🙈 😀 )edvin
05/04/2017, 9:24 AMedvin
05/04/2017, 11:50 AMsmartResize()
on any TableView
ron
05/04/2017, 11:50 AMron
05/04/2017, 11:50 AMedvin
05/04/2017, 11:55 AMsmartResize = true
as a parameter to the tableview builders, but that might be too much.edvin
05/04/2017, 12:01 PMmikehearn
05/04/2017, 12:46 PMedvin
05/04/2017, 1:31 PMedvin
05/04/2017, 1:32 PMedvin
05/04/2017, 1:33 PMFX.defaultSmartResize = false
defined, the builder could be defined as tableview(smartResize: Boolean = FX.defaultSmartResize)
for example.edvin
05/04/2017, 1:33 PMdefaultClosable
, defaultSavable
and friends.edvin
05/04/2017, 1:35 PMSmartResize.makeDefault = true
or something.carlw
05/04/2017, 2:02 PMkastork
05/04/2017, 2:03 PMkastork
05/04/2017, 2:03 PMmikehearn
05/04/2017, 2:04 PMedvin
05/04/2017, 2:15 PMmenuitem
builder wrong 🙂 The op block for menuitem is the actual action.edvin
05/04/2017, 2:15 PMaction
wrapper inside it, or change menuitem
to item
, which behaves like you expect.edvin
05/04/2017, 2:17 PMmenuitem
builder was made this way because it was assumed that you normally never wanted to further configure the menu item, just supply the action. That assumption was probably not good, and it also breaks with how the other builders works. Therefore, the item
builder was introduced. It might be time to deprecate the menuitem
builder, because it causes confusion. If you just want to configure an action, you'd just do item("My item").action { myAction() }
anyways.edvin
05/04/2017, 2:17 PMmenuitem
builder, but you see it keeps coming back to bite us in the ass 😢edvin
05/04/2017, 2:18 PMmenuitem(title) {}
to item(title).action {}
.